1661756 - [Protections Dashboard] Add VPN Card

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Erica Wright [:ewright]]

We will be adding a new VPN card to the protections dashboard.
We will also add a banner to the top of the dashboard for the first visit.
invision link

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1661756 - Add VPN Card and Banner

Comment 2

[Erica Wright [:ewright]]

Attachment: data reviiew request

Comment 3

[Chris H-C :chutten]

Comment on attachment 9173791 [details]
data reviiew request

Load-balancing to Megan

Comment 4

[Erica Wright [:ewright]]

Attachment: data review request

Some changes to the telemetry collection proposal. Adding a new doc.

Comment 5

[Erica Wright [:ewright]]

Comment on attachment 9173791 [details]
data reviiew request

data review request

Comment 6

[Megan McCorquodale]

Comment on attachment 9175569 [details]
data review request

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes, this is documented in the probe dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   Yes, users can opt out of telemetry.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   Not permanent data collection.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Category 2, interaction data.

5. Is the data collection request for default-on or default-off?
   Default on.

6. Does the instrumentation include the addition of any new identifiers?
   No new identifiers.

7. Is the data collection covered by the existing Firefox privacy notice?
   Yes.

8. Does there need to be a check-in in the future to determine whether to renew the data?
   Yes, check in at Firefox 86.

9. Does the data collection use a third-party collection tool?
   No.

---

data-review +

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/206a04ae2fa7
Add VPN Card and Banner r=prathiksha,flod,nhnt11

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out changeset for bc failures on browser_protections_telemetry.js.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=206a04ae2fa7fcd8db9f903b7d654edf033ea1fb&test_paths=browser%2Fcomponents%2Fprotections%2Ftest%2Fbrowser%2F&selectedTaskRun=PTgoIJDyTCeWTDOgat4cNQ.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=316096704&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/0073a85ce25bffd90e10e243518667c0f3004b6d

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60399347a777
Add VPN Card and Banner r=prathiksha,flod,nhnt11

Comment 10

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_protections_vpn.js

backout: https://hg.mozilla.org/integration/autoland/rev/dde5282e8b9a6e9b5750e90d5038a6c835013298

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=60399347a7779a3267ff179d2c5341c7394a36bd&group_state=expanded&selectedTaskRun=aZK0nkYzR-6sNZhpWjcJIA.0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316439950&repo=autoland&lineNumber=5013

[task 2020-09-23T00:51:02.295Z] 00:51:02 INFO - TEST-PASS | browser/components/protections/test/browser/browser_protections_vpn.js | VPN card is shown. - true == true -
[task 2020-09-23T00:51:02.295Z] 00:51:02 INFO - Buffered messages finished
[task 2020-09-23T00:51:02.296Z] 00:51:02 INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_vpn.js | Uncaught exception - undefined - timed out after 50 tries.
[task 2020-09-23T00:51:02.296Z] 00:51:02 INFO - Leaving test bound testVPNDoesNotShowChina
[task 2020-09-23T00:51:02.296Z] 00:51:02 INFO - GECKO(2300) | MEMORY STAT | vsize 19406275MB | vsizeMaxContiguous 66216501MB | residentFast 1186MB
[task 2020-09-23T00:51:02.296Z] 00:51:02 INFO - TEST-OK | browser/components/protections/test/browser/browser_protections_vpn.js | took 12075ms
[task 2020-09-23T00:51:02.296Z] 00:51:02 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-09-23T00:51:02.296Z] 00:51:02 INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_vpn.js | Found an unexpected tab at the end of test run: about:protections -

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e8c8e02db69
Add VPN Card and Banner r=prathiksha,flod,nhnt11

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 0e8c8e02db69 (bug 1661756) for browser_protections_vpn.js failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0e8c8e02db69ca8a3d0fe7f171de9ac005f0a7d1

Backout link: https://hg.mozilla.org/integration/autoland/rev/31b0acc21d10f6264aa1ea3533961891c8303acd

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316550472&repo=autoland&lineNumber=4964

....
[task 2020-09-24T02:09:41.418Z] 02:09:41     INFO - TEST-PASS | browser/components/protections/test/browser/browser_protections_vpn.js | VPN banner is hidden. - true == true - 
[task 2020-09-24T02:09:41.418Z] 02:09:41     INFO - Leaving test bound testVPNPromoBanner
[task 2020-09-24T02:09:41.418Z] 02:09:41     INFO - Entering test bound testVPNDoesNotShowChina
[task 2020-09-24T02:09:41.418Z] 02:09:41     INFO - Buffered messages logged at 02:09:35
[task 2020-09-24T02:09:41.419Z] 02:09:41     INFO - Enable showing the VPN card
[task 2020-09-24T02:09:41.419Z] 02:09:41     INFO - Check that vpn banner and card are able to show when conditions allow
[task 2020-09-24T02:09:41.419Z] 02:09:41     INFO - TEST-PASS | browser/components/protections/test/browser/browser_protections_vpn.js | VPN card is shown. - true == true - 
[task 2020-09-24T02:09:41.419Z] 02:09:41     INFO - Buffered messages finished
[task 2020-09-24T02:09:41.419Z] 02:09:41     INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_vpn.js | Uncaught exception - undefined - timed out after 50 tries.
[task 2020-09-24T02:09:41.419Z] 02:09:41     INFO - Leaving test bound testVPNDoesNotShowChina
[task 2020-09-24T02:09:41.420Z] 02:09:41     INFO - GECKO(6176) | MEMORY STAT | vsize 19406262MB | vsizeMaxContiguous 66206635MB | residentFast 1188MB
[task 2020-09-24T02:09:41.420Z] 02:09:41     INFO - TEST-OK | browser/components/protections/test/browser/browser_protections_vpn.js | took 12396ms
[task 2020-09-24T02:09:41.420Z] 02:09:41     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-09-24T02:09:41.421Z] 02:09:41     INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_vpn.js | Found an unexpected tab at the end of test run: about:protections - 
[task 2020-09-24T02:09:41.421Z] 02:09:41     INFO - checking window state
[task 2020-09-24T02:09:42.501Z] 02:09:42     INFO - GECKO(6176) | [Parent 6900, Gecko_IOThread] WARNING: file z:/build/build/src/ipc/chromium/src/base/process_util_win.cc, line 166
[task 2020-09-24T02:09:43.008Z] 02:09:43     INFO - GECKO(6176) | Completed ShutdownLeaks collections in process 8272
[task 2020-09-24T02:09:43.030Z] 02:09:43     INFO - GECKO(6176) | Completed ShutdownLeaks collections in process 2152
[task 2020-09-24T02:09:43.050Z] 02:09:43     INFO - GECKO(6176) | Completed ShutdownLeaks collections in process 10576
[task 2020-09-24T02:09:43.130Z] 02:09:43     INFO - GECKO(6176) | Completed ShutdownLeaks collections in process 7468
[task 2020-09-24T02:09:43.824Z] 02:09:43     INFO - GECKO(6176) | Completed ShutdownLeaks collections in process 6900
[task 2020-09-24T02:09:43.824Z] 02:09:43     INFO - TEST-START | Shutdown

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/534888954962
Add VPN Card and Banner r=prathiksha,flod,nhnt11

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/534888954962