Add line marker range getters
Categories
(Core :: Disability Access APIs, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Whiteboard: [mac2020_2])
Attachments
(4 files)
There are three parameterized attributes that return line text ranges with a given text marker:
AXLeftLineTextMarkerRangeForTextMarkerAXRightLineTextMarkerRangeForTextMarkerAXLineTextMarkerRangeForTextMarker
They work similar to the word range getters. Each one is slightly nuanced in where/how it searches for the line to return.
|
Assignee | |
Comment 1•3 years ago
|
||
There are at least 8 different methods for getting a range from an offset:
- left word
- right word
- line
- left line
- right line
- sentence
- paragraph
- range with same style.
Having a single wrapper and IPDL method for all of those with an enum would remove
a lot of redundancies.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
There are going to be a whole bunch of things we want to check for each
text marker in a document. I think loops should be avoided as much as possible,
but this lets us store a single array with everything we expect for each marker.
This is going to expand in the future.
Depends on D90936
|
|
Assignee | |
Comment 3•3 years ago
|
||
The left and right line getters don't seem to be used often by voiceover,
so I am not sure if they always return the expected result.
Depends on D90937
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b2ebd5b2f0bf Part 1: Unify all range from offset methods to one. r=morgan,nika https://hg.mozilla.org/integration/autoland/rev/40c7642562ee Part 2: Refactor mac basic text test. r=morgan https://hg.mozilla.org/integration/autoland/rev/34d5770a0518 Part 3: Add line boundary support in mac. r=morgan
|
|
Assignee | |
Comment 5•3 years ago
|
||
Pushed by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e447b16f091 Followup: eslint tests. r=dluca
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b2ebd5b2f0bf
https://hg.mozilla.org/mozilla-central/rev/40c7642562ee
https://hg.mozilla.org/mozilla-central/rev/34d5770a0518
https://hg.mozilla.org/mozilla-central/rev/4e447b16f091
Description
•