Closed Bug 1661760 Opened 8 months ago Closed 7 months ago

Add line marker range getters

Categories

(Core :: Disability Access APIs, defect, P1)

All
macOS
defect

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

(Whiteboard: [mac2020_2])

Attachments

(4 files)

There are three parameterized attributes that return line text ranges with a given text marker:

  • AXLeftLineTextMarkerRangeForTextMarker
  • AXRightLineTextMarkerRangeForTextMarker
  • AXLineTextMarkerRangeForTextMarker

They work similar to the word range getters. Each one is slightly nuanced in where/how it searches for the line to return.

Blocks: 1650333

There are at least 8 different methods for getting a range from an offset:

  1. left word
  2. right word
  3. line
  4. left line
  5. right line
  6. sentence
  7. paragraph
  8. range with same style.

Having a single wrapper and IPDL method for all of those with an enum would remove
a lot of redundancies.

Assignee: nobody → eitan
Status: NEW → ASSIGNED

There are going to be a whole bunch of things we want to check for each
text marker in a document. I think loops should be avoided as much as possible,
but this lets us store a single array with everything we expect for each marker.

This is going to expand in the future.

Depends on D90936

The left and right line getters don't seem to be used often by voiceover,
so I am not sure if they always return the expected result.

Depends on D90937

Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2ebd5b2f0bf
Part 1: Unify all range from offset methods to one. r=morgan,nika
https://hg.mozilla.org/integration/autoland/rev/40c7642562ee
Part 2: Refactor mac basic text test. r=morgan
https://hg.mozilla.org/integration/autoland/rev/34d5770a0518
Part 3: Add line boundary support in mac. r=morgan
You need to log in before you can comment on or make changes to this bug.