Print dialog's validated fields should prevent pasting invalid input
Categories
(Toolkit :: Printing, defect, P2)
Tracking
()
People
(Reporter: mtigley, Assigned: mtigley)
References
Details
(Whiteboard: [print2020_v81])
Attachments
(2 files, 1 obsolete file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Bug 1660060 introduces a keypress listener for the scale input UI component, which blocks invalid keys (non-numeric characters, "%", etc...) from being entered. As a result copy/paste/ctrl+a commands don't work. This is a problem since chrome supports this on Windows.
This issue should add a "paste" event handler that prevents invalid input from being entered.
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Marking as "leave-open" because a second patch is required to handle pasting for start and end page range
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b7b3e0312fe4 Prevent pasting invalid input into ScaleInput UI. r=emalysz
Comment 4•4 years ago
|
||
bugherder |
Assignee | ||
Comment 5•4 years ago
|
||
Assignee | ||
Comment 6•4 years ago
|
||
Depends on D89009
Updated•4 years ago
|
Updated•4 years ago
|
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/94205e4e0130 Add a paste event handler to PrintUIControlMixin that prevents invalid inputs. r=emalysz
Assignee | ||
Comment 8•4 years ago
|
||
Comment on attachment 9172790 [details]
Bug 1661776 - Prevent pasting invalid input into ScaleInput UI. r?emalysz
Beta/Release Uplift Approval Request
- User impact if declined: Users can paste invalid input into the percent scale, copies, and page range fields. This experience is inconvenient if invalid input was accidentally entered and can result in a confusing experience for the user trying to change the percent scale, copies, or page range values.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: STR:
- Copy "Invalid input" (or some non-numeric value) into your clipboard.
- Try pasting into either the percent scale, copies, or page range input fields.
Expected
Pasting invalid input should not be allowed.
Actual
The invalid input is pasted into the field.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small change to how numeric input fields handle invalid paste input. Only the percent scale, copies, and page range fields are affected.
- String changes made/needed:
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 9•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Comment on attachment 9172790 [details]
Bug 1661776 - Prevent pasting invalid input into ScaleInput UI. r?emalysz
Approved for 81.0b6.
Updated•4 years ago
|
Comment 11•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Comment 12•4 years ago
|
||
This issue is verified fixed using Firefox 81.0b7 (BuildId:20200906164749) and Firefox 82.0a1 (BuildId:20200907094115) on Windows 10 64bit, macOS 10.14 and Ubuntu 18.04 64bit.
Description
•