Closed Bug 1661790 Opened 4 years ago Closed 4 years ago

Allow configuring the name of the `virtualenv` used for builds

Categories

(Firefox Build System :: General, task)

Product:
Firefox Build System
Component:
General
Type:
task

Tracking

(firefox-esr78 fixed, firefox82 fixed)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- fixed
firefox82 --- fixed

People

(Reporter: rstewart, Assigned: rstewart)

References

Details

Attachments

(1 file)

Bug 1661790 - Allow configuring the name of the `virtualenv` used for builds
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-esr78+
Details | Review
No description provided.
Component: Python Test → General
Product: Testing → Firefox Build System
Version: Default → unspecified

We don't anticipate end users will actually care to do this, but it's useful especially for unit tests. For example, after bug 1659539, Python configure tests will run in a new, non-init_py3 virtualenv, and we'll want to target that virtualenv for configure rather than having it create a new virtualenv for no reason.

Pushed by rstewart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c9280955687
Allow configuring the name of the `virtualenv` used for builds r=nalexander

https://hg.mozilla.org/mozilla-central/rev/2c9280955687

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Comment on attachment 9172772 [details]
Bug 1661790 - Allow configuring the name of the virtualenv used for builds

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Not a large priority, but ensures that https://bugzilla.mozilla.org/show_bug.cgi?id=1659539 behaves more performantly.
  • User impact if declined: None
  • Fix Landed on Version: 82
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's a build-only patch
  • String or UUID changes made by this patch:
Attachment #9172772 - Flags: approval-mozilla-esr78?
Attachment #9172772 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: