Closed
Bug 1661809
Opened 4 years ago
Closed 4 years ago
use mach lint
Categories
(Testing :: mozperftest, enhancement, P4)
Testing
mozperftest
Tracking
(firefox82 fixed)
RESOLVED
FIXED
82 Branch
Tracking | Status | |
---|---|---|
firefox82 | --- | fixed |
People
(Reporter: tarek, Assigned: tarek)
Details
Attachments
(1 file)
now that mach lint added support for black, we can use it inside perftest-test
in that black command, instead of installing our own black/flake8, we can call mach lint --fix python/mozperftest
that will also ensure that we use the same linter versions than the review bots.
This call might need a little bit of wrapping work inside the command, to pass through the exit code
Assignee | ||
Comment 1•4 years ago
|
||
Removed our custom linter calls and use mach lint
Assignee | ||
Comment 2•4 years ago
|
||
Pushed by tziade@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/655ce94f20f3 use mach lint r=sparky DONTBUILD
Comment 4•4 years ago
|
||
Backed out for SM bustages
Backout link: https://hg.mozilla.org/integration/autoland/rev/6fb6f07fd8b081151baa7979542d9585d651e939
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315366651&repo=autoland&lineNumber=81154
Flags: needinfo?(tarek)
Pushed by tziade@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88fca1e48f23 use mach lint r=sparky
Comment 6•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(tarek)
You need to log in
before you can comment on or make changes to this bug.
Description
•