1661921 - Console Instant Value no refresh after page refresh

Status: VERIFIED FIXED

(DevTools :: Console, defect, P3)

Description

[Łukasz]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

Open page https://8o7d7.csb.app/

1. Open Firefox DevTools Console on this page
2. Type ciLS.length in Console - Instant Value is 1
3. Refresh page

Actual results:

Instant Value show old value, still show 1. This is confusing.

Expected results:

Instant Value should show new value - 2.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[colin.cazabet]

Hello, I cannot reproduce this bug when i follow the steps in the previous message.
Has this bug been fixed ?

Thank you

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

I can still reproduce it.
Another STR is:

1. Open a tab with data:text/html,<meta charset=utf8><a href=https://mozilla.org>mozilla.org</a>
2. Open the console, and type globalThis.location, without executing. (the instant evaluation is data:text/html,<meta charset=utf8><a href=https://mozilla.org>mozilla.org</a>)
3. Click on the link in the page, that will navigates it to mozilla.org

-> the instant evaluation does not change, it still the data url when it should be mozilla.org now

We have an action we call already when we want the instant evaluation to be re-evaluated (https://searchfox.org/mozilla-central/search?q=updateInstantEvaluationResultForCurrentExpression&redirect=false)
So we could try to call it from here: https://searchfox.org/mozilla-central/rev/72c7cef167829b6f1e24cae216fa261934c455fc/devtools/client/webconsole/webconsole-ui.js#401-404 , using dispatch like in https://searchfox.org/mozilla-central/rev/72c7cef167829b6f1e24cae216fa261934c455fc/devtools/client/webconsole/webconsole-ui.js#189

Do you want to be assigned to this bug Colin?

Comment 4

[colin.cazabet]

Okay i undertand now, yes I would like to give it a try please.
Thank you for the details it will help me a lot !

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Merci Colin :) The bug is now yours

Comment 6

[colin.cazabet]

Attachment: Bug 1661921 - [devtools] Console Instant Value no refresh after page refresh r=nchevobbe

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58d174f77ba4
[devtools] Console Instant Value no refresh after page refresh r=nchevobbe

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/58d174f77ba4

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on Firefox 99(20220330194208) on Linux x86_64(Ubuntu 20.04) using the steps from Comment 3. Verified as fixed on FIrefox 100.0b7(20220417185951) and Nightly 101.0a1(20220419093010) on the same OS.