1661928 - calender don't save password - httprealm is "" (can't store passwords for ftp hosted calendars)

Status: RESOLVED WONTFIX

(Calendar :: General, defect)

Description

[andreas.hanisch]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

Create a new calendar on ftp share.
Credentials for server is typed in and save password is checked

This bug is in Version 68 too

Actual results:

Password is not stored
exception "Can't add a login without a httpRealm or formActionOrigin." from _CheckLogin() in LoginManager.jsm Line 283

Next synchronisation ask for server credentials again

Expected results:

httpRealm should be a copy of origin, so the password can be stored and found for next synchronisations.

In PromtAuth() CalAuthUtils.jsm Line240 the call of PasswordManagerSave is done with aAuthInfo.realm which is ""
So this Parameter in call PromtAuth() has to be different to save the password of ftp servers.

Comment 1

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/rev/7156143da17c283114591163b3074e622484ee6e/calendar/base/modules/utils/calAuthUtils.jsm#244

Comment 3

[andreas.hanisch]

After some debugging:
promptAuth() calculates hostRealm.passwordRealm in line 215 or 216
hostRealm.passwordRealm = aChannel.URI.host + ":" + port + " (" + aAuthInfo.realm + ")";

In line 220 or 221 there is a search for the saved password
let pwInfo = this.getPasswordInfo(hostRealm, requestedUser);

If no password was found and the user filled in the messagebox and checked save password
than
calauth.passwordManagerSave() in line 240 or 241 is called but with parameter aAuthInfo.realm and not hostRealm.passwordRealm

As aAuthInfo.realm is a part of hostRealm.passwordRealm this call should be corrected in this way:
calauth.passwordManagerSave(
aAuthInfo.username,
aAuthInfo.password,
hostRealm.prePath,
hostRealm.passwordRealm
);

Comment 4

[Magnus Melin [:mkmelin]]

Can you submit a patch?

Comment 5

[andreas.hanisch]

May be.
What is the procedure to do it?

Comment 6

[andreas.hanisch]

Attachment: Bug 1661928 - fix calender don't save password

Comment 7

[Magnus Melin [:mkmelin]]

Thanks for the patch! To get the patch reviewed you set the "review" flag of the patch to a reviewer. I've done that for you now.

Comment 8

[andreas.hanisch]

Hello Magnus,

please set status-thunderbird_esr78 to affected.

Comment 9

[Geoff Lankow (:darktrojan)]

Comment on attachment 9193467 [details] [diff] [review]
Bug 1661928 - fix calender don't save password

This would break everything else that comes through here. Yes, a non-empty string needs to be passed here, but aAuthInfo.realm is the right string in most cases. hostRealm.passwordRealm is bogus and can actually be removed. Unfortunately, I should also tell you that FTP capability is being discontinued, so you're probably wasting your time fixing it.

Comment 10

[Magnus Melin [:mkmelin]]

I guess we should wontfix this then.