1661959 - Crash in [@ CxxThrowException | Botan::hex_decode]

Status: RESOLVED DUPLICATE of bug 1653884

(MailNews Core :: Security: OpenPGP, defect)

Description

[Wayne Mery (:wsmwk)]

all crashes are version 78, at least for the past month.

Crash report: https://crash-stats.mozilla.org/report/index/857f563e-6fdc-4efc-b34c-a5ee10200830

Top 10 frames of crashing thread:

0 kernelbase.dll RaiseException 
1 rnp.dll CxxThrowException /builds/worker/workspace/obj-build/comm/third_party/rnp/f:/dd/vctools/crt/vcruntime/src/eh/throw.cpp:129
2 rnp.dll Botan::hex_decode comm/third_party/botan/src/lib/codec/hex/hex.cpp:112
3 rnp.dll Botan::hex_decode comm/third_party/botan/src/lib/codec/hex/hex.cpp:192
4 rnp.dll std::_Func_impl_no_alloc<`lambda at /builds/worker/checkouts/gecko/comm/third_party/botan/src/lib/ffi/ffi.cpp:264:37', int>::_Do_call 
5 rnp.dll botan_hex_decode comm/third_party/botan/src/lib/ffi/ffi.cpp:264
6 rnp.dll rnp_hex_decode comm/third_party/rnp/src/lib/misc.cpp:440
7 rnp.dll str_to_locator comm/third_party/rnp/src/lib/rnp.cpp:3418
8 rnp.dll rnp_locate_key comm/third_party/rnp/src/lib/rnp.cpp:3507
9 xul.dll ffi_call_win64 

Comment 1

[Wayne Mery (:wsmwk)]

same?
https://crash-stats.mozilla.org/signature/?signature=Botan%3A%3Ahex_decode&product=Thunderbird&date=%3E%3D2020-08-16T00%3A00%3A00.000Z&date=%3C2020-08-30T23%3A59%3A00.000Z&_sort=-date

Comment 2

[Kai Engert [:KaiE:]]

Yes same.

I've reported the issue at https://github.com/rnpgp/rnp/issues/1287

The RNP library should be fixed to prevent this crash, by using try/catch

Comment 3

[Kai Engert [:KaiE:]]

Nickolay, once this is fixed, could you please point us to an updated RNP revision suitable for inclusion in the Thunderbird stable branch? Thanks.

Comment 4

[Nickolay Olshevsky]

Kai, sure. Actually I'm surprised why and how this could happen, let's first resolve this (together with RSA key generation issue, probably).

Comment 5

[Wayne Mery (:wsmwk)]

https://github.com/rnpgp/rnp/issues/1287 notes on Sept 24, 2020, "The issue is fixed by using the /EHs clang compiler flag. (Which Botan's build system already uses, but the Thunderbird build system didn't...)"

And the crashes ended in September. Did we implement the fix mentioned above?

Comment 6

[Rob Lemley [:rjl]]

(In reply to Wayne Mery (:wsmwk) from comment #5)

And the crashes ended in September. Did we implement the fix mentioned above?

Yes, in bug 1653884.