1662066 - Use a single `waitFor` test helper and make it highlight which precise assertion failed.

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

First, there is probably three distinct implementation, all being the same:
https://searchfox.org/mozilla-central/search?q=function+waitFor%28&path=devtools&case=false&regexp=false

They probably conflict with:
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/test/head.js#747
which should be removed in favor of using EventEmitter.once directly. This old helper was useful back in the days, when we weren't having such once method...

And the worse is that these waitFor method do not give any context about what failed.
No stack, no particular context message is required to be passed.
We typically only get:

0:13.24 FAIL Uncaught exception - waitFor - timed out after 500 tries.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1662066 - Remove netmonitor waitFor test helper.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1662066 - Use a single waitFor test helper implementation.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1662066 - Print more information when waitFor() test helper fails.

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&selectedTaskRun=IV4C8OZLQ3CRe4GSHTCCrA.0&revision=86bafd4d851ffe1d309071ed42c231fcbd366011

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81e54ebee65d
Remove netmonitor waitFor test helper. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/53fd170899a1
Use a single waitFor test helper implementation. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/2ab790a92a79
Print more information when waitFor() test helper fails. r=nchevobbe

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/81e54ebee65d
https://hg.mozilla.org/mozilla-central/rev/53fd170899a1
https://hg.mozilla.org/mozilla-central/rev/2ab790a92a79