1662183 - Sign in to Firefox menu is enabled even when DisableFirefoxAccounts policy is true

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[jp]

Attachment: not_disabled.png

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

Enable Policy DisableFirefoxAccounts to true

Actual results:

The menu "Sign in to Firefox" is enabled with options to login, turn on sync, set up sync, send tabs to other devices ...

Expected results:

This menu should be removed.

Comment 1

[jp]

Attachment: not_disabled2.png

Comment 2

[Mike Kaply [:mkaply]]

This is a regression that happened around the 10th or 11th of August. I'm still looking into it.

This is actually a sync bug. Some new code isn't handling the

identity.fxaccounts.enabled

preference when set to false.

Comment 3

[Mike Kaply [:mkaply]]

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c742e992415fb5d467ab812caf70c5d30d37d387&tochange=ee09cb88af177571304759bc05c760e3d82fd1ed

Points to:

https://bugzilla.mozilla.org/show_bug.cgi?id=1634030

Comment 4

[Mike Kaply [:mkaply]]

To recreate, put the following in a file called policies.json in bin/distribution

{
"policies": {
"DisableFirefoxAccounts": true
}
}

Just setting identity.fxaccounts.enabled to false and restarting should work as well.

Comment 5

[Mike Kaply [:mkaply]]

Note that our test for this policy just tests that Sync is disabled, it doesn't test UI touchpoints.

Comment 6

[Mike Kaply [:mkaply]]

Looking into this, here's the code that used to hide everything:

https://searchfox.org/mozilla-release/source/browser/base/content/browser-sync.js#1516

  onFxaDisabled() {
    const toHide = [...document.querySelectorAll(".sync-ui-item")];
    for (const item of toHide) {
      item.hidden = true;
    }
  },

That doesn't work because things are now lazy. Simplest fix might be to switch to CSS for hiding the items instead of using .hidden?

Comment 7

[Emma Malysz]

Attachment: Bug 1662183, hide fxa button from main menu when identity.fxaccounts.enabled is false

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1634030

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0e35053e222
hide fxa button from main menu when identity.fxaccounts.enabled is false r=Gijs,mkaply

Comment 10

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=CoqdJh7bQpqUKZHr54aL7Q.0&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=bc&revision=c0e35053e222761f04780150987150ac0350650c&failure_classification_id=2

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314658191&repo=autoland&lineNumber=12213

Backout: https://hg.mozilla.org/integration/autoland/rev/6de217c870da1bca0141ab610eb46b9aec91b840

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8838f9ba7f14
hide fxa button from main menu when identity.fxaccounts.enabled is false r=Gijs,mkaply

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8838f9ba7f14

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval.

Comment 15

[Emma Malysz]

Comment on attachment 9173279 [details]
Bug 1662183, hide fxa button from main menu when identity.fxaccounts.enabled is false

Beta/Release Uplift Approval Request

• User impact if declined: Users with identity.fxaccounts.enabled will steel see fxa item in main menu.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open Firefox

2. Set identity.fxaccounts.enabled
3. Quit Firefox
4. Open Firefox
5. Click on the main hamburger menu
6. Notice fxa button (first at top) is not there

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No strings
• String changes made/needed: n/a

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173279 [details]
Bug 1662183, hide fxa button from main menu when identity.fxaccounts.enabled is false

Approved for 81.0b9.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/99258fedf6be

Comment 18

[Alexandra Martin]

Attachment: Display with Sync disabled.png

Confirmed that Sync is disabled for Windows 10 x64bit and MacOS 10.14 with latest Beta 81.0 (20200917005511) and Nightly 82.0a1 (20200917142508) by setting identity.fxaccounts.enabled to false. According to Comment 5 the UI is not covered here, should a new bug report be filed?

Comment 19

[Mike Kaply [:mkaply]]

Are you still seeing UI anywhere? This should have all been fixed by this bug. Comment 5 was just pointing out the code where we were doing the work before.

Comment 20

[Alexandra Martin]

On every tested build the menu is displayed like that after the Sync is disabled with the pref and the Firefox build is restarted.

Comment 21

[Mike Kaply [:mkaply]]

OK, I don't see any Sync on that menu, so we should be fine. Might be worth opening a bug to remove the top separator though.