Closed Bug 1662212 Opened 4 years ago Closed 4 years ago

Add telemetry to measure encrypted playback usage

Categories

(Core :: Audio/Video: Playback, task, P2)

Desktop
All
task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: bryce, Assigned: bryce)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

We should add telemetry to help us figure out how much playback involves encrypted media. We have prior art in existing probes that measure playback time[0].

[0] https://searchfox.org/mozilla-central/rev/d54712b9644b49cec6cc90a9e0c325fdfab04e7c/toolkit/components/telemetry/Histograms.json

Add 3 probes

  • Play time for encrypted elements.
  • Play time for Clearkey elements.
  • Play time for Widevine elements.

Comment on attachment 9173174 [details]
data_review_request.md

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in the probe definition files and the Probe Dictionary.

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out.

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :bryce.

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, interaction data.

  1. Is the data collection request for default-on or default-off?

Default-on.

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes.

  1. Does there need to be a check-in in the future to determine whether to renew the data?

n/a; permanent collection.

  1. Does the data collection use a third-party collection tool?

No.

Attachment #9173174 - Flags: data-review?(bmiroglio) → data-review+
Attachment #9173166 - Attachment description: Bug 1662212 - Add telemetry to track play time of encrypted HTMLMediaElements. → Bug 1662212 - Add telemetry to track play time of encrypted HTMLMediaElements. r?drno

The one call site for ReportTelemetry in HTMLMediaElement is currently nested
inside a if (aSuspendElement) {. I.e. telemetry is only recorded when
suspending the element. Update our description to reflect this.

Depends on D88895

Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d770d6ba0a5
Add telemetry to track play time of encrypted HTMLMediaElements. r=drno
https://hg.mozilla.org/integration/autoland/rev/067329cceb69
Amend description on playback probes stating telemetry is collected on resume, as this appears false. r=drno
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

While I'm working on bug1685399, I noticed that those encrypted related probes would only be collected on video. So encrypted audio won't be count. I wonder if we should collect audio as well.

(In reply to Alastor Wu [:alwu] from comment #7)

While I'm working on bug1685399, I noticed that those encrypted related probes would only be collected on video. So encrypted audio won't be count. I wonder if we should collect audio as well.

That would be useful and help us have a more complete picture.

I've been watching as the values for these probes have come in and stabilized, and there is another unexpected property: the Widevine playtime is significantly higher than the encrypted playtime. The widevine playtime is assessed based on if we have a mediakeys with a widevine key system set on a media element, the encrypted time is based on if mEncrypted is true[0].

The discrepancy is surprising to me. It's something I'd like to investigate further.

[0] https://searchfox.org/mozilla-central/rev/014fe72eaba26dcf6082fb9bbaf208f97a38594e/dom/html/HTMLMediaElement.cpp#5481

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: