1662292 - Flip pref for newtab stories in regions for AT, CH and BE

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Scott [:thecount] Downe]

We've got approval to do this now, it should just be a default pref change.

Comment 1

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: Just a pref flip, because we now have approval for launching de in a few more regions.

Comment 2

[Scott [:thecount] Downe]

Attachment: Bug 1662292 - Enabling Pocket stories in more regions with German speakers.

Comment 3

[Scott [:thecount] Downe]

To test:

1. Follow instructions here to setup both a German langpack https://firefox-source-docs.mozilla.org/browser/components/newtab/docs/v2-system-addon/geo_locale.html#setting-custom-geo-locale-and-update-channels
2. Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
3. Set browser.search.region to "DE" then "CH" then "BE" then "AT"
4. For each of those, you want to restart, then go to about:newtab#devtools-ds, and click "refresh cache"
5. Open a new tab.

Expected, for each region in step 3, you should see newtab stories in German in the newtab opened in step 5.

Comment 4

[Scott [:thecount] Downe]

Comment on attachment 9173250 [details]
Bug 1662292 - Enabling Pocket stories in more regions with German speakers.

Beta/Release Uplift Approval Request

• User impact if declined: It's a pref flip to enable newtab stories in more regions. So impact is more active users goals.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: To test:

1. Follow instructions here to setup both a German langpack https://firefox-source-docs.mozilla.org/browser/components/newtab/docs/v2-system-addon/geo_locale.html#setting-custom-geo-locale-and-update-channels
2. Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
3. Set browser.search.region to "DE" then "CH" then "BE" then "AT"
4. For each of those, you want to restart, then go to about:newtab#devtools-ds, and click "refresh cache"
5. Open a new tab.

Expected, for each region in step 3, you should see newtab stories in German in the newtab opened in step 5.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a pref flip to enable more region to use existing functionality already used by other regions.
• String changes made/needed: none

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2efb7a933a9c
Enabling Pocket stories in more regions with German speakers. r=gvn

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2efb7a933a9c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173250 [details]
Bug 1662292 - Enabling Pocket stories in more regions with German speakers.

Approved for 81.0b6.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/74d955184cce

Comment 9

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the "Recommended by Pocket" stories are displayed for all 4 regions in German by following the STR provided in comment 4 using Firefox Nightly 82.0a1 DE (Build ID: 20200903151816) and Firefox Beta 81.0b6 DE (Build ID: 20200903205131) on Windows 10 x64, macOS 10.15, and Ubuntu Linux 18.04.