Closed Bug 1662309 Opened 4 years ago Closed 4 years ago

Update fluent-rs to 0.12

Categories

(Core :: Internationalization, task, P3)

task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

fluent 0.12 has been released in May, together with a bunch of helper libs like unic-langid and fluent-langneg.
This update is necessary for bug 1660392.

Assignee: nobody → gandalf
Blocks: 1660392
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad6c81e11152
Update fluent-rs to 0.12. r=kamidphish

Backed out changeset ad6c81e11152 (bug 1662309) for CheckCapacity assertion failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=webgl2-ext&fromchange=1a0b21debe92db3bf4db1d04c41da9b3aa8625f1&tochange=ea855bdc21ea4920f8e67288dfba33c687215dd7&selectedTaskRun=MVB4G2NeT6mTIV5fA3VAXQ.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/ea855bdc21ea4920f8e67288dfba33c687215dd7

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314540939&repo=autoland&lineNumber=1601

[task 2020-09-01T04:56:42.429Z] 04:56:42     INFO - TEST-START | dom/canvas/test/webgl-conf/generated/test_2_conformance2__glsl3__vector-dynamic-indexing.html
[task 2020-09-01T04:56:42.429Z] 04:56:42     INFO - TEST-SKIP | dom/canvas/test/webgl-conf/generated/test_2_conformance2__glsl3__vector-dynamic-indexing.html | took 0ms
[task 2020-09-01T04:56:42.430Z] 04:56:42     INFO - Running manifest: dom\canvas\test\webgl-conf\generated-mochitest.ini
[task 2020-09-01T04:56:43.234Z] 04:56:43     INFO -  Z:\task_1598935769\build\tests\bin\pk12util.exe: PKCS12 IMPORT SUCCESSFUL
[task 2020-09-01T04:56:43.366Z] 04:56:43     INFO - MochitestServer : launching [u'Z:\\task_1598935769\\build\\tests\\bin\\xpcshell.exe', '-g', 'Z:\\task_1598935769\\build\\application\\firefox', '-f', 'Z:\\task_1598935769\\build\\tests\\bin\\components\\httpd.js', '-e', "const _PROFILE_PATH = 'c:\\\\users\\\\task_1598935769\\\\appdata\\\\local\\\\temp\\\\tmpqu4o6y.mozrunner'; const _SERVER_PORT = '8888'; const _SERVER_ADDR = '127.0.0.1'; const _TEST_PREFIX = undefined; const _DISPLAY_RESULTS = false;", '-f', 'Z:\\task_1598935769\\build\\tests\\mochitest\\server.js']
[task 2020-09-01T04:56:43.367Z] 04:56:43     INFO - runtests.py | Server pid: 6004
[task 2020-09-01T04:56:43.370Z] 04:56:43     INFO - runtests.py | Websocket server pid: 744
[task 2020-09-01T04:56:43.382Z] 04:56:43     INFO - runtests.py | SSL tunnel pid: 9380
[task 2020-09-01T04:56:43.809Z] 04:56:43     INFO -  Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2020-09-01T04:56:43.828Z] 04:56:43     INFO -  [6004, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 119
[task 2020-09-01T04:56:43.829Z] 04:56:43     INFO -  [6004, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 119
[task 2020-09-01T04:56:43.829Z] 04:56:43     INFO -  [6004, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 119
[task 2020-09-01T04:56:43.830Z] 04:56:43     INFO -  [6004, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 119
[task 2020-09-01T04:56:43.830Z] 04:56:43     INFO -  [6004, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 119
[task 2020-09-01T04:56:43.909Z] 04:56:43     INFO -  [6004, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp, line 378
[task 2020-09-01T04:56:43.959Z] 04:56:43     INFO - runtests.py | Running with scheme: http
[task 2020-09-01T04:56:43.959Z] 04:56:43     INFO - runtests.py | Running with e10s: True
[task 2020-09-01T04:56:43.960Z] 04:56:43     INFO - runtests.py | Running with fission: False
[task 2020-09-01T04:56:43.960Z] 04:56:43     INFO - runtests.py | Running with cross-origin iframes: False
[task 2020-09-01T04:56:43.961Z] 04:56:43     INFO - runtests.py | Running with serviceworker_e10s: True
[task 2020-09-01T04:56:43.961Z] 04:56:43     INFO - runtests.py | Running with socketprocess_e10s: False
[task 2020-09-01T04:56:43.961Z] 04:56:43     INFO - runtests.py | Running tests: start.
[task 2020-09-01T04:56:43.961Z] 04:56:43     INFO - 
[task 2020-09-01T04:56:44.132Z] 04:56:44     INFO - Application command: Z:\task_1598935769\build\application\firefox\firefox.exe -marionette --wait-for-browser -foreground -profile c:\users\task_1598935769\appdata\local\temp\tmpqu4o6y.mozrunner
[task 2020-09-01T04:56:44.151Z] 04:56:44     INFO - runtests.py | Application pid: 7320
[task 2020-09-01T04:56:44.152Z] 04:56:44     INFO - TEST-INFO | started process GECKO(7320)
[task 2020-09-01T04:56:44.579Z] 04:56:44     INFO - GECKO(7320) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to c:\users\task_1598935769\appdata\local\temp\tmpqu4o6y.mozrunner\runtests_leaks.log
[task 2020-09-01T04:56:44.579Z] 04:56:44     INFO - GECKO(7320) | [8540, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 246
[task 2020-09-01T04:56:44.921Z] 04:56:44     INFO - GECKO(7320) | [8540, StreamTrans #1] WARNING: (debug) mSafeStream->Finish() failed within nsBufferedOutputStream::Flush()! Possible dataloss.: file /builds/worker/checkouts/gecko/netwerk/base/nsBufferedStreams.cpp, line 1006
[task 2020-09-01T04:56:44.921Z] 04:56:44     INFO - GECKO(7320) | [8540, StreamTrans #1] WARNING: failed to save prefs file! possible data loss: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp, line 2951
[task 2020-09-01T04:56:46.273Z] 04:56:46     INFO - GECKO(7320) | [2020-09-01T04:56:46Z WARN  rkv::backend::impl_safe::environment] `load_ratio()` is irrelevant for this storage backend.
[task 2020-09-01T04:56:46.737Z] 04:56:46     INFO - GECKO(7320) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to c:\users\task_1598935769\appdata\local\temp\tmpqu4o6y.mozrunner\runtests_leaks_gpu_pid5248.log
[task 2020-09-01T04:56:46.737Z] 04:56:46     INFO - GECKO(7320) | [5248, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 246
[task 2020-09-01T04:56:47.138Z] 04:56:47     INFO - GECKO(7320) | 1598936207124	Marionette	TRACE	Marionette enabled
[task 2020-09-01T04:56:47.338Z] 04:56:47     INFO - GECKO(7320) | 1598936207333	Marionette	TRACE	Received observer notification toplevel-window-ready
[task 2020-09-01T04:56:47.408Z] 04:56:47     INFO - GECKO(7320) | Assertion failure: CheckCapacity(aLength) (String is too large.), at /builds/worker/checkouts/gecko/xpcom/string/nsTSubstring.cpp:49
[task 2020-09-01T04:56:47.694Z] 04:56:47     INFO -  Initializing stack-fixing for the first stack frame, this may take a while...
[task 2020-09-01T04:56:47.853Z] 04:56:47     INFO -  fix-stacks error: failed to run `Z:\task_1598935769\build\tests\bin\fileid.exe` for `Z:\task_1598935769\build\application\firefox\xul.dll`
[task 2020-09-01T04:56:47.853Z] 04:56:47     INFO - GECKO(7320) | #01: Ordinal0 [Z:\task_1598935769\build\application\firefox\xul.dll + 0x28f57e]
...
Flags: needinfo?(gandalf)

Here's the real stack:

[task 2020-09-01T04:59:53.309Z] 04:59:53     INFO - Thread 0 (crashed)
[task 2020-09-01T04:59:53.310Z] 04:59:53     INFO -  0  xul.dll!nsTSubstring<char>::nsTSubstring(char*, unsigned int, mozilla::detail::StringDataFlags, mozilla::detail::StringClassFlags) [nsTSubstring.cpp:ad6c81e11152d987f87037d1329f31de16530d77 : 49 + 0x0]
[task 2020-09-01T04:59:53.310Z] 04:59:53     INFO -     rax = 0x00007ffb15877f7e   rdx = 0x00007ffb58e1a640
[task 2020-09-01T04:59:53.310Z] 04:59:53     INFO -     rcx = 0x00007ffb42cd3038   rbx = 0x000001c736987660
[task 2020-09-01T04:59:53.310Z] 04:59:53     INFO -     rsi = 0x00000077925fd520   rdi = 0x00000077925fd580
[task 2020-09-01T04:59:53.310Z] 04:59:53     INFO -     rbp = 0x00000077925fd7d0   rsp = 0x00000077925fd4a0
[task 2020-09-01T04:59:53.310Z] 04:59:53     INFO -      r8 = 0x00000077925f74e8    r9 = 0x0000000000000000
[task 2020-09-01T04:59:53.310Z] 04:59:53     INFO -     r10 = 0x0000000000000000   r11 = 0x00000077925f8b30
[task 2020-09-01T04:59:53.311Z] 04:59:53     INFO -     r12 = 0x000001c736987660   r13 = 0x000001c7369ad000
[task 2020-09-01T04:59:53.311Z] 04:59:53     INFO -     r14 = 0x000001c734af9070   r15 = 0x000001c736904828
[task 2020-09-01T04:59:53.311Z] 04:59:53     INFO -     rip = 0x00007ffb0ccc957d
[task 2020-09-01T04:59:53.311Z] 04:59:53     INFO -     Found by: given as instruction pointer in context
[task 2020-09-01T04:59:53.311Z] 04:59:53     INFO -  1  xul.dll!nsLanguageAtomService::GetUncachedLanguageGroup(nsAtom*) const [nsLanguageAtomService.cpp:ad6c81e11152d987f87037d1329f31de16530d77 : 189 + 0x34]
[task 2020-09-01T04:59:53.312Z] 04:59:53     INFO -     rbx = 0x000001c736987660   rbp = 0x00000077925fd7d0
[task 2020-09-01T04:59:53.312Z] 04:59:53     INFO -     rsp = 0x00000077925fd4e0   r12 = 0x000001c736987660
[task 2020-09-01T04:59:53.312Z] 04:59:53     INFO -     r13 = 0x000001c7369ad000   r14 = 0x000001c734af9070
[task 2020-09-01T04:59:53.312Z] 04:59:53     INFO -     r15 = 0x000001c736904828   rip = 0x00007ffb0ceffefa
[task 2020-09-01T04:59:53.312Z] 04:59:53     INFO -     Found by: call frame info
[task 2020-09-01T04:59:53.312Z] 04:59:53     INFO -  2  xul.dll!nsLanguageAtomService::GetLanguageGroup(nsAtom*, bool*) [nsLanguageAtomService.cpp:ad6c81e11152d987f87037d1329f31de16530d77 : 146 + 0x8]
[task 2020-09-01T04:59:53.312Z] 04:59:53     INFO -     rbx = 0x000001c736987660   rbp = 0x00000077925fd7d0
[task 2020-09-01T04:59:53.313Z] 04:59:53     INFO -     rsp = 0x00000077925fd640   r12 = 0x000001c736987660
[task 2020-09-01T04:59:53.313Z] 04:59:53     INFO -     r13 = 0x000001c7369ad000   r14 = 0x000001c734af9070
[task 2020-09-01T04:59:53.313Z] 04:59:53     INFO -     r15 = 0x000001c736904828   rip = 0x00007ffb0ceff57e
[task 2020-09-01T04:59:53.313Z] 04:59:53     INFO -     Found by: call frame info
[task 2020-09-01T04:59:53.313Z] 04:59:53     INFO -  3  xul.dll!mozilla::StaticPresData::GetFontPrefsForLang(nsAtom*, bool*) [StaticPresData.cpp:ad6c81e11152d987f87037d1329f31de16530d77 : 229 + 0x8]
[task 2020-09-01T04:59:53.313Z] 04:59:53     INFO -     rbx = 0x000001c736987660   rbp = 0x00000077925fd7d0
[task 2020-09-01T04:59:53.314Z] 04:59:53     INFO -     rsp = 0x00000077925fd690   r12 = 0x000001c736987660
[task 2020-09-01T04:59:53.314Z] 04:59:53     INFO -     r13 = 0x000001c7369ad000   r14 = 0x000001c734af9070
[task 2020-09-01T04:59:53.314Z] 04:59:53     INFO -     r15 = 0x000001c736904828   rip = 0x00007ffb114a8fa9
[task 2020-09-01T04:59:53.314Z] 04:59:53     INFO -     Found by: call frame info

Maybe I shouldn't have assume that this will work:

#[no_mangle]
pub unsafe extern "C" fn unic_langid_get_script(
    langid: &LanguageIdentifier,
    len: *mut u32,
) -> *const u8 {
    if let Some(script) = langid.script {
        let script = script.as_str();
        *len = script.len() as u32;
        script.as_bytes().as_ptr()
    } else {
        std::ptr::null()
    }
}

Previous version had:

    let script = langid.script().unwrap_or("");
    *len = script.len() as u32;
    script.as_bytes().as_ptr()
Flags: needinfo?(gandalf)
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ea91616c192
Update fluent-rs to 0.12. r=kamidphish
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac66d358f822
Update fluent-rs to 0.12. r=kamidphish
Blocks: 1634631
Flags: needinfo?(gandalf)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: