Closed Bug 1662316 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25311 - More accurate layout shift tracking for texts

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox82 fixed)

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25311 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25311
Details from upstream follow.

b'Xianzhu Wang <wangxianzhu@chromium.org>' wrote:

More accurate layout shift tracking for texts

Previously when a text shifted, we assumed the whole area below the
text in the containing block shifted, which might report too big
shifted area, e.g. if the text shift was just in one line.

Now pass the logical height of the shifted text and calculate the
shifted are for the text only. Shifts of other texts below are
checked separately.

Bug: 1121405
Change-Id: I029c5dfcf6d0537a9be4f8c33cac9d63bd4b4f1d
Reviewed-on: https://chromium-review.googlesource.com/2386842
WPT-Export-Revision: ccf8b5f1b1d4573bde5301a6696b84cbf7c255e7

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 2

Chrome

OK : 2
PASS: 1
FAIL: 1

Safari

OK : 2
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/layout-instability/inline-flow-shift-one-line.html
Inline flow movement.: FAIL (Chrome: FAIL, Safari: FAIL)
/layout-instability/inline-flow-shift-vertical-rl.html
Vertical-rl inline flow movement.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/45fb240822c9 [wpt PR 25311] - More accurate layout shift tracking for texts, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Regressions: 1663644
You need to log in before you can comment on or make changes to this bug.