1662395 - Intermittent comm/mail/components/extensions/test/browser/browser_ext_tabs_events.js | undefined - Expected: onCreated, Actual: onUpdated -

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: geoff [at] darktrojan.net
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=314542480&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/CY4y3UmXSDqjL7a2bL8hbw/runs/0/artifacts/public/logs/live_backing.log

---

This is not bug 1657061.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1662395 - Keep a reference to TabProgressListeners and improve testing of tabs.onUpdated. r?mkmelin

TabProgressListener QIs to nsISupportsWeakReference, which means the instances we add only survive
until the next GC. Also if we change the layout of the 3-pane window, the progress listener on
#messagepane disappears.

Once all that is fixed we can more reliably test events on the tabs API.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0af9452aeb51
Keep a reference to TabProgressListeners and improve testing of tabs.onUpdated. r=mkmelin

Comment 3

[Intermittent Failures Robot]

13 failures in 2984 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 13

Platform breakdown:

• linux64: 5
• macosx1014-64: 4
• windows7-32: 2
• windows10-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1662395&startday=2020-08-31&endday=2020-09-06&tree=all

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9173538 [details]
Bug 1662395 - Keep a reference to TabProgressListeners and improve testing of tabs.onUpdated. r?mkmelin

[Approval Request Comment]
User impact if declined: some WebExt events don't work correctly
Testing completed (on c-c, etc.): on beta since 82
Risk to taking this patch (and alternatives if risky): there's some risk but I haven't seen any problems other than bug 1662912 which also should be uplifted

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9173538 [details]
Bug 1662395 - Keep a reference to TabProgressListeners and improve testing of tabs.onUpdated. r?mkmelin

Scratch that. The platform changes that happened in 79 to make it not worthwhile backporting.