1662434 - sheets of paper not updated when switching destination to "Save to PDF"

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Martin Balfanz [:mbalfanz]]

STR:

1. Open the print dialog on any page
2. Select a physical printer as destination
3. Change the number of copies to something other than 1
4. Switch change the destination to "Save to PDF"

ER: The number of pages should shown in the top right corner should reflect the length of document as if it was only 1 copy
AR: The number of pages in the top right corner shows the total number of sheets as if the physical printer was still selected

Comment 1

[Martin Balfanz [:mbalfanz]]

Thinking about it, for "Save to PDF" we may not want to show "Sheets of paper" at all. Or we could show the number of pages instead, which might be good when selecting a custom range.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

(This may also get fixed when we fix bug 1662331…)

Comment 3

[Mark Striemer [:mstriemer]]

This is because we don't change the numCopies setting when the printer changes. We do the sheetCount * numCopies calculation on our own, so using sheetCount directly here won't help us.

We could update the PrintSettingsViewProxy to dynamically return a value for numCopies, so something like this.get(target, "willSaveToFile") ? 1 : target.numCopies. It might be better to reset numCopies when the printer changes if the new printer is a PDF printer though, since if we don't reset numCopies we'll still ask the PDF printer to print that many copies.

Comment 4

[Tania Maity (:tmaity)]

Hi Mike,
could you please in setting a severity value for this ticket?

Comment 5

[Blake Winton (:bwinton) (:☕️)]

(And this. In general I can do the priority/severity for stuff in Toolkit::Printing for the next few releases, so that we don't bother Mike. 😉)

Comment 6

[Tania Maity (:tmaity)]

Understood :) Thanks for updating it.

Comment 7

[Mark Striemer [:mstriemer]]

Attachment: Bug 1662434 - Show correct sheet count for PDF printers when numCopies is set r?emalysz

Depends on D89796

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/397260e89398
Show correct sheet count for PDF printers when numCopies is set r=emalysz

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/397260e89398

Comment 10

[Oana Botisan, Desktop QA]

I managed to reproduce the issue on an older version of Nightly.
I retested everything using latest Nightly 83.0a1 and Firefox 82.0b2 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The issue is not reproducing anymore.