Closed Bug 1662477 Opened 9 months ago Closed 9 months ago

Don't toggle local one-offs if urlbar privacy preferences are flipped

Categories

(Firefox :: Address Bar, task, P2)

Product:
Firefox
Component:
Address Bar
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Iteration:
82.2 - Sep 7 - Sep 20
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: blocked-ux)

Attachments

(1 file)

Bug 1662477 - Don't toggle local one-offs if urlbar privacy preferences are flipped. r=adw
47 bytes, text/x-phabricator-request
Details | Review

Currently local one-off are hidden if you disable privacy preferences in the urlbar.
That is not coherent with other sources in the urlbar, even if bookmarks are disabled you can still restrict the search to bookmarks, it's your explicit opt-in.
Indeed a user may not want normally to see history/bookmarks/open tabs results, but may want to opt-in to search them when needed.

We should allow the users to hide local one-offs as part of the search preferences, that is what Bug 1657790 is tracking.

We must still get final sign-off from Verdi on this.

Is this different from bug 1659205?

yes, that bug is about exposing options to hide/show local one-offs, this is about stopping hiding them when urlbar privacy options are changed. It's basically a revert of some of the initial implementation of local one-offs.

Assignee: nobody → mak
Status: NEW → ASSIGNED
Iteration: --- → 82.2 - Sep 7 - Sep 20
Priority: P3 → P2
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/079bf1a54040
Don't toggle local one-offs if urlbar privacy preferences are flipped. r=adw

https://hg.mozilla.org/mozilla-central/rev/079bf1a54040

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.