1662481 - Update RNP to snapshot from 2020-09-01

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement)

Description

[Kai Engert (:KaiE:)]

Update RNP to snapshot from 2020-09-01
to pick up correctness fixes.

Comment 1

[Kai Engert (:KaiE:)]

Let's test revision d6477b0ffc685d100c35f1796d2aeb325b365c0d which includes correctness fixed, but doesn't include build env improvements.

Comment 2

[Kai Engert (:KaiE:)]

Attachment: Bug 1662481 - Update RNP to snapshot from 2020-09-01. r=rjl

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c944c87a07d8
Update RNP to snapshot from 2020-09-01. r=rjl

Comment 4

[Kai Engert (:KaiE:)]

Comment on attachment 9173390 [details]
Bug 1662481 - Update RNP to snapshot from 2020-09-01. r=rjl

Haven't seen problem reports with c-c, so let's uplift to beta as the next testing step.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9173390 [details]
Bug 1662481 - Update RNP to snapshot from 2020-09-01. r=rjl

[Triage Comment]
Approved for beta

Comment 6

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-beta/rev/a4f6ed6d78fb1c1231ac9afe5df9bc8ea509d4b6

Comment 7

[Kai Engert (:KaiE:)]

Comment on attachment 9173390 [details]
Bug 1662481 - Update RNP to snapshot from 2020-09-01. r=rjl

I haven't noticed issues running this update, and haven't seen problem reports.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9173390 [details]
Bug 1662481 - Update RNP to snapshot from 2020-09-01. r=rjl

[Triage Comment]
Approved for esr78.

Comment 9

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-esr78/rev/cbe93a3d02acbd6c25016e6f02ae3e872c0caa9e
78.2.2

Comment 10

[Kai Engert (:KaiE:)]

Uplifts to c-c and esr78 were slightly different.

Diff:

third_party/rnp/module.ver
-WIN32_MODULE_NAME=@MOZ_APP_DISPLAYNAME@ @MOZ_APP_VERSION@ rnp
+WIN32_MODULE_NAME=@MOZ_RNP_DIST_INFO@

File rnp/src/tests/data/test_messages/message.txt.cr contain different number of plus signs.

No idea what went wrong.

Let's fix this difference in the next RNP lib bug.

Comment 11

[Rob Lemley [:rjl]]

(In reply to Kai Engert (:KaiE:) from comment #10)

Uplifts to c-c and esr78 were slightly different.

Diff:

third_party/rnp/module.ver
-WIN32_MODULE_NAME=@MOZ_APP_DISPLAYNAME@ @MOZ_APP_VERSION@ rnp
+WIN32_MODULE_NAME=@MOZ_RNP_DIST_INFO@

This is from bug 1657333. There were some mozbuild changes in 81 that triggered it and esr78 is unaffected. If it's causing problems we should be able to uplift.

Comment 12

[Kai Engert (:KaiE:)]

Ok thanks for the pointer. I had simply noticed the difference in message.txt.cr and were looking for other differences.
If that bug was trunk only, we don't need to uplift.