1662484 - Do not allow wrapping SourceSurfaceOffset around null surfaces

Status: RESOLVED FIXED

(Core :: Graphics, defect, P1)

Description

[Miko Mynttinen]

The patch for bug 1627616 did not catch all the cases where SourceSurfaceOffset::mSurface could end up being nullptr.
This patch fixes the only other callsite where SourceSurfaceOffset is constructed, and adds a release assert in SourceSurfaceOffset::SourceSurfaceOffset().

Comment 1

[Miko Mynttinen]

Attachment: Bug 1662484 - Do not allow wrapping SourceSurfaceOffset around null surfaces r=mstange

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23935d3834d6
Do not allow wrapping SourceSurfaceOffset around null surfaces r=mstange

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/23935d3834d6

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Hi Miko, do we want this on Beta/ESR78? Please nominate if yes :)

Comment 5

[Miko Mynttinen]

Comment on attachment 9173398 [details]
Bug 1662484 - Do not allow wrapping SourceSurfaceOffset around null surfaces r=mstange

Beta/Release Uplift Approval Request

• User impact if declined: This is a follow-up to bug 1627616 that should fix the remaining cases of this crash signature (often occurring during device resets on Windows)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1627616
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk because the fix is effectively a null-pointer check that avoids the crash.
• String changes made/needed:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173398 [details]
Bug 1662484 - Do not allow wrapping SourceSurfaceOffset around null surfaces r=mstange

Approved for 81.0b9.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/781a6c7fea72

Comment 8

[Miko Mynttinen]

Comment on attachment 9173398 [details]
Bug 1662484 - Do not allow wrapping SourceSurfaceOffset around null surfaces r=mstange

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes one of the top crashes.
• User impact if declined: Crashes, possibly related to device resets or OOM events, when surface creation fails.
• Fix Landed on Version: 81
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk because the fix is effectively a null-pointer check that avoids the crash.
• String or UUID changes made by this patch:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173398 [details]
Bug 1662484 - Do not allow wrapping SourceSurfaceOffset around null surfaces r=mstange

Approved for 78.4esr.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/70dbf5235e62