Open Bug 1662613 Opened 6 years ago Updated 6 years ago

[wpt-sync] Sync PR 25350 - [css-pseudo] Support text properties in ::marker

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Product:
Core
Component:
Layout: Generated Content, Lists, and Counters
Type:
task

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25350 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25350
Details from upstream follow.

b'Oriol Brufau <obrufau@igalia.com>' wrote:

[css-pseudo] Support text properties in ::marker

The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568
that inherited properties that apply to text can be set on ::marker and
should affect the marker text.

Therefore, this patch allows 'hyphens', 'letter-spacing', 'line-break',
'overflow-wrap', 'tab-size', 'word-break', and 'word-spacing' in marker.

Note it was already possibly to set these properties in the list item
and the ::marker would inherit them. This patch just lets authors set
them directly on the ::marker.

I would have allowed 'text-justify' too but it's not enabled by default
and in LayoutNG it has no effect on inline boxes (bug 1124043), so it
didn't seem worth it.

Bug: 1031667

TEST=external/wpt/css/css-pseudo/marker-hyphens.html
TEST=external/wpt/css/css-pseudo/marker-letter-spacing.html
TEST=external/wpt/css/css-pseudo/marker-line-break.html
TEST=external/wpt/css/css-pseudo/marker-overflow-wrap.html
TEST=external/wpt/css/css-pseudo/marker-tab-size.html
TEST=external/wpt/css/css-pseudo/marker-word-break.html
TEST=external/wpt/css/css-pseudo/marker-word-spacing.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html

Some tests fail in legacy because ::markers with 'content: normal' are
not implemented with actual text.

Change-Id: I2086854796fd355928591ee4c85f241337b33445

Reviewed-on: https://chromium-review.googlesource.com/2388384
WPT-Export-Revision: 26cb37f2bbcdd3ed279131df032292579219b370

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests

Status Summary

Firefox

OK : 2
PASS: 93
FAIL: 35[Gecko-windows7-32-debug] 42[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-opt, GitHub]

Chrome

OK : 2
PASS: 98
FAIL: 37

Safari

OK : 2
PASS: 49
FAIL: 86

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-pseudo/parsing/marker-supported-properties.html
Property font value 'italic small-caps 900 expanded 25px / 50px Ahem' in ::marker: FAIL linked bug:Bug 1655828

New Tests That Don't Pass

/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
Animation of font in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Animation of white-space in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of hyphens in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of letter-spacing in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of line-break in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of overflow-wrap in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of tab-size in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of text-transform in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Animation of word-break in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of word-spacing in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of list-style in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Transition of font in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Transition of white-space in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of hyphens in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of letter-spacing in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of line-break in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of overflow-wrap in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of tab-size in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of text-transform in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Transition of word-break in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of word-spacing in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of list-style in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-pseudo/parsing/marker-supported-properties.html
Property font value 'italic small-caps 900 expanded 25px / 50px Ahem' in ::marker: FAIL (Chrome: PASS, Safari: PASS)
Property white-space value 'nowrap' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property animation value '1s linear 2s infinite alternate forwards paused anim' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Property transition value 'display 1s linear 2s' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Property hyphens value 'none' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property letter-spacing value '10px' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property line-break value 'anywhere' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property overflow-wrap value 'anywhere' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property tab-size value '10px' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property text-transform value 'uppercase' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Property word-break value 'break-word' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property word-spacing value '10px' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property list-style value 'inside url('foo') decimal' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-pseudo/marker-hyphens.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/marker-letter-spacing.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/marker-line-break.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/marker-overflow-wrap.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/marker-tab-size.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-pseudo/marker-word-break.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/marker-word-spacing.html: FAIL (Chrome: FAIL, Safari: FAIL)

You need to log in before you can comment on or make changes to this bug.