1662703 - [css-ui] Change appearance: button to only apply to buttons

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Mozilla Apprentice]

A resolution was made for csswg-drafts/#5174.

[css-ui] Change appearance: button to only apply to buttons

• RESOLVED: Limit 'appearance: button' to buttons once we figure out what buttons are

Discussion.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1662703 - Make appearance: button behave like auto. r=heycam

As per https://github.com/w3c/csswg-drafts/issues/5174.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1662703 - Tweak appearance: button usage in browser/ and toolkit/. r=dao,gijs

The protections.css declaration is not needed, because you're setting
backgrounds and borders anyways so native appearance is disabled.

The button.css change needs to turn into a -moz-default-appearance +
appearance combo, but since it's in three different places, just put it
in xul.css instead.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56e1f7f0268b
Tweak appearance: button usage in browser/ and toolkit/. r=dao

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/baab244deeb0
Make appearance: button behave like auto. r=heycam

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 7

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=MRyNPzp2S9u41aQj0iuMXA.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=os%2Cx%2C10.14%2Copt%2Creftests%2Ctest-macosx1014-64%2Fopt-reftest-e10s%2Cr3&revision=baab244deeb06579c5d498ee5a0bbeb0bac3c19a

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315271846&repo=autoland&lineNumber=10340

Backout: https://hg.mozilla.org/integration/autoland/rev/012726c6a965af26b5890db11bc3ebf9ef441ccf

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/56e1f7f0268b

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a3863563468
Make appearance: button behave like auto. r=heycam

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/7a3863563468

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25576 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Rachel Andrew]

The BCD has already been merged for this, so I've just added a note in the 82 release notes.