The “View Saved Logins” part of the “Password Import Autocomplete” suggestion is wrongly displayed after the user has seen the suggestion more than 3 times
Categories
(Firefox :: Messaging System, defect, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | unaffected |
| firefox81 | --- | affected |
| firefox82 | --- | affected |
People
(Reporter: romartin, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.49 MB,
image/gif
|
Details |
[Affected Versions]:
- Firefox Nightly 82.0a1 (Build ID: 20200901214943)
- Firefox Beta 81.0b5 (Build ID: 20200901203141)
[Affected Platforms]:
- Windows 10 (x64)
- macOS 10.15
[Prerequisites]:
- Have a new profile created.
- Have Google Chrome installed.
- Have multiple credentials saved on more than 4 different websites in Google Chrome (eg. Facebook.com, twitter.com, instagram.com, messenger.com).
[Steps to reproduce]:
- Start the Firefox Browser with the profile from prerequisites.
- Navigate to “facebook.com”.
- Click the “Username/Email” or “Password” field and wait 10 seconds.
- Open a new tab and navigate to “twitter.com”.
- Click the “Username/Email” or “Password” field and wait 10 seconds.
- Open a new tab and navigate to “instagram.com”.
- Click the “Username/Email” or “Password” field and wait 10 seconds.
- Open a new tab and navigate to “messenger.com”.
- Click the “Username/Email” or “Password” field.
- Go to the tab from step 2 (“facebook.com” tab).
- Click the “Username/Email” field and observe the field.
[Expected results]:
- The “Password Import Autocomplete” suggestion is correctly NOT displayed.
[Actual results]:
- The “View Saved Logins” part of the “Password Import Autocomplete” suggestion box is displayed and functional.
[Notes]:
- If the “signon.suggestImportCount” has reached 0 and you open a new tab with the previously used website, the issue is not reproducible.
- If a previously opened page is refreshed, the issue is no longer reproducible.
- If a browser restart is performed the issue is not reproducible.
- Attached a screen recording of the issue.
Comment 2•6 years ago
|
||
(In reply to Robert Martin [:romartin], Ecosystem QA from comment #0)
- If a previously opened page is refreshed, the issue is no longer reproducible.
Yeah, if the page is kept open, the state of marking the autocomplete as handled by password vs formfill isn't re-updated.
Comment 3•6 years ago
|
||
NI Ed to help re-triage and close if this is working as intended. Thanks
Comment 4•6 years ago
|
||
This is indeed a bug, and the behavior was introduced by bug 1618314 where we stop showing suggestions after showing them 3 times with a 10 second delay. One possible solution is to undo markAsLoginManagerField potentially with a call to markAsAutofillField (?) so we avoid showing the "view saved logins" password autocomplete. Alternatively, we could modify the "stop showing" behavior to allow it to keep showing on the same page if it was previously shown. The latter might be preferrable if users might try to reshow the import suggestion, e.g., switching away from Firefox and back.
Comment 5•5 years ago
|
||
Triaged on Dec 7.
Updated logins generate/show false/improper logins.
I am not on facebook and is currently loosing my most important sites and mailprovider, as they do not want to restore my mail and its contents.
Accounts containing vital correspondence and documentation of about 12 years.
| Reporter | ||
Comment 7•4 years ago
|
||
Hello Susanne,
Thank you for reaching out!
The issue you are encountering is different than the one mentioned in this bug. I suggest you file a different issue for the behavior you are encountering in the "Toolkit" product and the "Password Manager" component (in case you can select them). Also, any extra information helps speed up the process.
Hi, thank you for anwsering
The Passwordgenerator/function saving passwords is unreliable. When changing codes it turns out to create wrong codes that are not corresponding to the related accounts. When creating new code the old is deleted. Thus I have lost important accounts are closed due to lack of traffik. I discovered this since January 4.th, but it might have occured earlier, as it also seemingly 'doubled'/renamed accounts, creating varoius different codes for seemingly identical accounts. I don't know if it created subaccounts. My firefox is updated and so is my Mac.
I don't know where to answer as your mail (the response 'button' in your answer doesn't work.
Comment 9•4 years ago
|
||
NI Sergey to help triage and if the feature is still in use
Comment 10•4 years ago
|
||
Lowering priority and severity of this.
"View Saved Logins" is not a part of the import, it's a gateway to saved logins. When Password Manager does not match anything user may want to go to their passwords to find entry they need. Pressing down key in the input will produce same autocomplete.
The only bug I see is that when import suggestions are being turned off, we still open empty autocomplete on focus event. With only View Saved Logins footer there.
Feel free to move this bug to Password Manager component.
P.S. we are considering simplifying the way import in autocomplete works, so this bug may not even be worth fixing.
Description
•