Remove willDestroy JSWindowActor method and update docs
Categories
(Core :: DOM: Content Processes, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: cpeterson, Assigned: enndeakin)
References
Details
Attachments
(1 file)
willDestroy
documentation recommends:
You should override this method if you have any cleanup you need to do before going away.
But willDestroy
is not guaranteed to be called. The docs should instead recommend doing clean up (that doesn't require sending a message) in didDestroy
.
Comment 1•4 years ago
•
|
||
Re-purposing this bug to remove willDestroy method as it was misused and we haven't found a strong reason to have it around. All uses of it will be replaced by didDestroy in bug 1651802. We also need to remove references to it in https://firefox-source-docs.mozilla.org/dom/ipc/jsactors.html#willdestroy .
Reporter | ||
Comment 2•4 years ago
|
||
Steven, can we close this willDestroy
meta bug now? Are there any more uses of willDesroy
in code or docs that need to be removed?
Comment 3•4 years ago
|
||
(In reply to Chris Peterson [:cpeterson] from comment #2)
Steven, can we close this
willDestroy
meta bug now? Are there any more uses ofwillDesroy
in code or docs that need to be removed?
It looks like at least TestProcessActor
[1] still has a willDestroy()
and that the actual machinery for willDestroy
hasn't been removed at this point. If I recall correctly, Neil was going to be finishing that off? Either way I think Neil would be in a better position to fully answer this question and I've needinfo'd them.
Assignee | ||
Comment 4•4 years ago
|
||
Yes, I am looking into removing the code that invokes willDestroy still.
Assignee | ||
Comment 5•4 years ago
|
||
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/257be68f7462 remove willDestroy callback from JSActors, r=nika
Comment 7•4 years ago
|
||
bugherder |
Description
•