1662818 - System modal has the “All” radio button selected even if a custom page range was set from the new UI

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: ModalAll.gif

Affected versions

• 82.0a1 (BuildId:20200902095359)
• 81.0b5 (BuildId:20200901203141)

Affected platforms

• Windows 10 64bit
• Ubuntu 18.04 64bit (I will get back with a confirmation on Ubuntu tomorrow, marking this as affect until then).

Unaffected platforms

• macOS 10.14

Steps to reproduce

1. Launch Firefox.
2. Access the following link
3. Hit Ctrl + P
4. Select a physical printer and set a custom range between 1 and 2 (out of 3 total pages).
5. Click the “Print using the system dialog” option.
6. Print the page via the system dialog.

Expected result

• The System dialog opens and the Pages radio button from the “Page Range” section is selected (because a custom range has been selected in the UI) and the page range from the system modal reflects the values from the new UI.

Actual result

• The System dialog opens and the All radio button is selected from the “Page Range” section. The page range from the system modal reflects the values from the new UI but having the “All” radio button selected will go ahead and print all the pages.

Regression Window

• This seems to be a regression.
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3822966f80969a59b7034df220b156d6a513b878&tochange=1b228ca5d679f60bc5f40f646e0515dd84670863
• Possible regressor: Bug 1653389

Additional Information

• For further information regarding this issue please observe the attached screencast.
• Setting the ALL platforms for now until I get a confirmation that Ubuntu is affected as well.
• [Suggested Severity] S3

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Emma!

It seems that mozregression pointed out Bug 1653389, show error if page range input is invalid r=fluent-reviewers,sfoster,flod for causing this regression.

I can see that Bug 1661852 has the same output but that's a little bit different since I think that covers a different scenario.

Can you please take a look?

Thank you!

Comment 2

[Emma Malysz]

I think this may be covered in Bug 1661852, but I'll have to double check

Comment 3

[Emil Ghitta, QA [:emilghitta]]

I can still reproduce this issue using Firefox 82.0a1 (BuildId:20200903094553). (Bug 1661852 has landed in m-c)

Comment 4

[Emma Malysz]

Attachment: Bug 1662818, select pages radio button from system dialog if custom range is specified

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7117f0f30770
select pages radio button from system dialog if custom range is specified r=emilio

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7117f0f30770

Comment 7

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using old Nightly (2020-09-02), verified that this is fixed in Firefox 82.0b3 on Windows 10 and Ubuntu 18.04 but not in macOS 10.15.7.
I also see this issue with Chrome as well. Could it be that this is intended not to work on MacOS?

Comment 8

[Emma Malysz]

No, this should still work on MacOS. I'm seeing it work in my local build, but it doesn't seem to work on Nightly.. I'll look into this

Comment 9

[Emma Malysz]

I filed 1668894 for macOS. That seems to occur for changing settings when "Save to pdf" is the selected printer.

Comment 10

[Bogdan Maris, Desktop Test Engineering]

Got it, I'll close this bug as verified and track the remaining work for macOS in bug 1668894.

Comment 11

[Maria Berlinger [:mberlinger], Services QA]

https://testrail.stage.mozaws.net/index.php?/cases/view/1084039

Comment 12

[Oana Botisan, Desktop QA]

I can still reproduce this issue using Nightly 93.0a1 on Ubuntu 18.04 x64.

Comment 13

[Emma Malysz]

If you input a specific custom range into the field, then it should switch to "custom".
However, if no range is inputted with custom selected, it'll still show as all. This should be addressed in bug 1660929

Comment 14

[Oana Botisan, Desktop QA]

I used a valid range and then clicked on “Print using the system dialog” option. The only difference from the STR in comment 0 is that I used "Save to Pdf" option. The issue is not reproducing while using a physical printer.