1662831 - Phonetic label not visible in Account Settings > Edit Card dialog

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2020-09-01 18-13-56.png

The phonetic label is not visible in the Account Settings > Edit Card dialog accessible from the first tab.

Maybe related to bug 1652256, but I'm not sure if it was regressed by it.

Comment 1

[Richard Marti (:Paenglab)]

Maybe the phonetic fields shouldn't be shown. See the commit message from bug 405762: Remove the phonetic fields from vcard editing as they aren't valid for vcards and the data gets lost.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1662831-hide-phonetic-on vcard.patch

Hide all phonetic fields in vCard dialog as they aren't stored.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9173731 [details] [diff] [review]
1662831-hide-phonetic-on vcard.patch

Review of attachment 9173731 [details] [diff] [review]:
-----------------------------------------------------------------

Good, this fixes the issue.
It seems that this was regressed during the XUL to HTML input conversion.
If this affects 78 we should uplift it.

Comment 4

[Alessandro Castellani [:aleca]]

This affects also 78 but the patch doesn't apply cleanly.
We need to create a variation for 78.
Richard, is something you're able to do or you want me to take care of that?

Comment 5

[Richard Marti (:Paenglab)]

Bug 1653647 needs to be applied first on ESR. Then this patch should apply.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ba536f37352f
Remove all phonetic fields from vcard editing. r=aleca DONTBUILD

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9173731 [details] [diff] [review]
1662831-hide-phonetic-on vcard.patch

[Approval Request Comment]
User impact if declined: Unneeded fields are shown in vcard dialog
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Bug 1653647 needs to be applied first

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9173731 [details] [diff] [review]
1662831-hide-phonetic-on vcard.patch

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 81.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/f312fc9c6f17

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9173731 [details] [diff] [review]
1662831-hide-phonetic-on vcard.patch

[Triage Comment]
Approved for esr78.

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.2.2:
https://hg.mozilla.org/releases/comm-esr78/rev/9e367dad9cfa