1662881 - Some OpenPGP signature states should report "unknown" rather than "mismatch"

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert (:KaiE:)]

As reported in bug 1624676, if a correspondent's key has state "undecided", we currently set the state "mismatch" in the UI. This is wrong, we should set the state "unknown".

The same can be said if we don't have any meta information in the key/certificate, and therefore cannot make a comparison, this should also be "unknown".

State "mismatch" should be reserved to a scenario when the meta information (email) in the key/certificate clearly doesn't match the email sender information.

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Bug 1662881 - Some OpenPGP signature states should report "unknown" rather than "mismatch". r=aleca

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/52635fa7f970
Some OpenPGP signature states should report "unknown" rather than "mismatch". r=aleca

Comment 3

[Wayne Mery (:wsmwk)]

Comment on attachment 9173757 [details]
Bug 1662881 - Some OpenPGP signature states should report "unknown" rather than "mismatch". r=aleca

[Triage Comment]
Approved for beta

Comment 4

[Kai Engert (:KaiE:)]

Thanks for approving.

In the approval request, I wanted to say:

This change is a no-op unless icons are changed (currently both these states map to the same icon).

Comment 5

[Kai Engert (:KaiE:)]

Comment on attachment 9173757 [details]
Bug 1662881 - Some OpenPGP signature states should report "unknown" rather than "mismatch". r=aleca

see previous comment

Comment 6

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-beta/rev/7be4bc69d95d040e5d5a4439d8bc3996d0b7bcbe
81.0b3

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9173757 [details]
Bug 1662881 - Some OpenPGP signature states should report "unknown" rather than "mismatch". r=aleca

[Triage Comment]
Approved for esr78.

Comment 8

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-esr78/rev/03c2805fb7fa2ab597cdc51d8fea01c30c97f3d0
78.2.2