1662893 - Refactor bootstrap to reflect that the state_dir and topsrcdir are both mandatory

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Ricky Stewart]

Attachment: Bug 1662893 - Refactor `bootstrap` to reflect that the `~/.mozbuild` state directory and a local checkout are both mandatory

bootstrap is written in such a way that we don't necessarily assume the existence of either the global state directory (~/.mozbuild) or a local checkout of mozilla-central. The independence from ~/.mozbuild is a design decision that may have been appropriate at some point, but today it's arguably useless to continue executing bootstrap without a global state directory (we install a bunch of build dependencies there, as well as the mach virtualenvs that are needed for running non-bootstrap mach commands after bug 1656993). The independence from a local checkout is an artifact of the old design of python/mozboot/bin/bootstrap.py, which is no longer necessary as of bug 1647792.

With that in mind, 1) throw errors if we can't create the global state directory or find the topsrcdir, and 2) remove all existing conditionals of the form "if the global state directory exists" or "if the root of the checkout exists" since these conditions are always going to be true in practice.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4f631604a0c
Refactor `bootstrap` to reflect that the `~/.mozbuild` state directory and a local checkout are both mandatory r=glandium

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a4f631604a0c