166296 - "browse" button in "open" dialog button returns garbage after picking a file

Status: RESOLVED WORKSFORME

(Core Graveyard :: Security: UI, defect, P3)

Description

[bill]

reproducable: always.
latest tried version: Mozilla 1.1 RTM
OS: Mac OS X 10.1.5, 10.2

Steps to reproduce:
Open the preferences window
Choose "Privacy&Security->Certificates->Manage Security Devices..."
Choose "Load"
When asked to choose a module filename, click "browse..."
Proceed to pick a file (it doesn't matter what the file is called or where it's
stored in order to see this bug)
Once the desired file is select, click OK
You'll be back at the "load module" dialog but notice how the resulting
"filename" is now a string of garbage.

Desired result: provide a proper fully-qualified path and file name.

Comment 1

[Greg K.]

Confirmed using FizzillaCFM/2002083017 on 10.1.5. Reassigning to Security: General.

Comment 2

[Stephane Saux]

This is a PSM bug.

Comment 3

[Stephane Saux]

kai

Comment 4

[Kai Engert [:KaiE:]]

Are we sure the resulting string is really garbage? Or is it just some Mac
specific file path?

The code obtains
  nsIFilePicker.file
which is of type
  nsILocalFile
and accesses attribute
  persistentDescriptor

A comment for persistentDescriptor says
  "DO NOT TRY TO INTERPRET IT AS HUMAN READABLE TEXT!"

I'm just starting to learn Mac, so I can only guess: Is it possible that all is
fine, and the only problem here is confusion about a non human readable
represenatation of the selected file name?

If my suspicion is correct, is there a better way to provide a human readable
represenatation of the selected path?

Comment 5

[bill]

Clicking on "OK" to accept the non-human-readable string results in a failure to
add the new security module.

Comment 6

[John Unruh]

Confirming. Browsing to the file on the Mac doesn't work. You have to type in
the actual location, such as "Macintosh HD:pkcs11.shlb". Then you can add the
device. Otherwise adding the device fails.

Comment 7

[Kai Engert [:KaiE:]]

We need help from a nsILocalFile / nsIFile guru.

What should we use to access, display and store the native path of a file, that
works on all platforms?

Comment 8

[Doug Turner (:dougt)]

kai, on the mac, persistent descriptors are base-64 encoded alias records. 
clearly, this shouldn't be displayed ot the user.  

If you must display something to the use, just use the leaf name.  If the leaf
name isn't enough, use the path.

Do access the nsFile's content, either use the Open method, or use necko.

All of the above will work XP.  

Comment 9

[bill]

not sure if this helps, but I noticed that the "browse..." button when adding
helper applications works just fine.  maybe you can re-use that code or examine
it to see how someone else got it to work on the mac in OS X.

Comment 10

[Kai Engert [:KaiE:]]

changing obsolete psm* target to --- (unspecified)

Comment 11

[Kai Engert [:KaiE:]]

reassign bug owner.
mass-update-kaie-20120918

Comment 12

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Somewhere along the line the use of persistentDescriptor was removed, so I think this is WFM.