1662962 - The `mailto` external protocol dialog is not displayed until favicon requests time out.

Status: RESOLVED FIXED

(Firefox :: File Handling, defect)

Description

[nayinain]

Attachment: Capture 2020-09-03 13-22-21.webm

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

1. Set the application that opens mailto protocol to Always ask in about:preferences.
2. Click a mailto-link (e.g. <[e-mail]>)

Actual results:

The mailto external protocol dialog is not displayed until favicon requests time out. (Google is restricts access in some countries and regions.)

Expected results:

It should be displayed immediately.

---

Sorry for my bad English.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1661030

Comment 2

[:Gijs (he/him)]

I guess we should do (some subset of) three things
(a) have a timeout so we don't wait for the load event forever (maybe 1-2 seconds? or check if we're getting paint events in the hidden dialog and if so use those)
(b) update this specific dialog so it adds http(s) based favicons after the load event fires and
(c) consider shipping favicons for the builtin icons (which may require some build/dialog logic as the provided default mail handlers are localizable and so different in different locales...).

Comment 3

[Emma Zühlcke [:emz]]

Attachment: Bug 1662962 - Defer favicon load for the protocol handler dialog. r=gijs!

Dialogs loaded via SubDialog only show once they are loaded.
This defers inserting the favicon URIs into the DOM until after
the load event, so that slow loads don't keep the dialog hidden.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85fbbd4b1962
Defer favicon load for the protocol handler dialog. r=Gijs

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/85fbbd4b1962