Closed Bug 1662985 Opened 1 year ago Closed 1 year ago

Move ExternalPixel and friends from APZPublicUtils.h to Units.h

Categories

(Core :: Panning and Zooming, task)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: kats, Assigned: grey.lila, Mentored)

Details

(Whiteboard: [apz-outreachy][lang=c++])

Attachments

(1 file)

InputData.h is including APZPublicUtils.h because it wants to use the ExternalPixel types. And InputData.h is included everywhere, so reducing the transitive include graph would be nice. Moving the ExternalPixel types to Units.h along with the other pixel types allow breaking the InputData.h -> APZPublicUtils.h dependency.

Mentor: botond
Whiteboard: [apz-outreachy]
Mentor: kats
Whiteboard: [apz-outreachy] → [apz-outreachy][lang=c++]

Moving the ExternalPixel types from APZPublicUtils.h to Units.h

Assignee: nobody → grey.lila

Moving the ExternalPixel types from APZPublicUtils.h to Units.h to
reduce the transitive include graph from that dependency.

Signed-off-by: Joey Salazar <grey.lila@yahoo.com>

Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dc359f15f0d6
Move the ExternalPixel types r=kats
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.