1662993 - [wpt-sync] Sync PR 25378 - [PeerConnection] Surface generated ICE candidates in localDescription.

Status: NEW

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 25378 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25378
Details from upstream follow.

b'Henrik Bostr\xc3\xb6m <[e-mail]>' wrote:

[PeerConnection] Surface generated ICE candidates in localDescription.

CL https://chromium-review.googlesource.com/c/chromium/src/+/2323359
implemented the spec-compliant behavior of having internal slots for
SDP as to not prematurely surface descriptions of pending SLD, SRD or
addIceCandidate operations.

But that CL forgot the changes to the localDescription due to ICE
candidates being generated and "onicecandidate" firing. This caused a
regression in M87.

This CL adds test coverage for this in WPT and fixes the bug by
surfacing all descriptions at OnIceCandidate.

Bug: chromium:1124384
Change-Id: Ifb11d6416772b87b9076ff6238e909928c66af6c

Reviewed-on: https://chromium-review.googlesource.com/2390747
WPT-Export-Revision: 0201dd58c01f3ddbef72b2cd3c652d80e1d5efca

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=29525ea2fc0214898001a5addcd7873b9c725dce

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Links

GitHub PR Head
GitHub PR Base