1663009 - setComposeDetails handling of commas in address names

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[musiquegraeme]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

I started an email and one of the addresses was in the form Name, job <address>
I pressed send and my addon uses setComposeDetails to expand addresses.

Actual results:

setComposeDetails (in the compose API) expanded the address but now it was Name <> in pink. The address was sent correctly to setComposeDetails but it took the comma between name and job as indication of a new address and so somehow removed the rest of the "name" and the address.

Expected results:

It should have handled the comma in the name as part of the name and not an indication to start a new address.

Comment 1

[Thomas D. (:thomas8)]

(In reply to musiquegraeme from comment #0)

I started an email and one of the addresses was in the form Name, job <address>
I pressed send and my addon uses setComposeDetails to expand addresses.

Can you give an example of "expanding" addresses?

Comment 2

[musiquegraeme]

Not really significant - the point was simply that setComposeDetails took the addresses that were in getComposeDetails and mishandled any commas in the name. I just did another test where there was no mailing list entry but the addon got the details with getComposeDetails and then sent the same addresses back with setComposeDetails and turned an address with a comma in the name like Name , job <Address> into Name <>

Of course the answer to your question is that the addon in question PopMailListRecipients 2 and expands any mail lists in the addresses to the component emails.

Comment 3

[Thomas D. (:thomas8)]

My Bug 1663067 reports similar symptoms.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1663009 - Correctly interpret addresses passed as strings to setComposeDetails. r?mkmelin

Instead of just using strings as-is, use the header parser to read and reformat them. This resolves issues with commas.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/221920c8e758
Correctly interpret addresses passed as strings to setComposeDetails. r=mkmelin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/db01f53031b8
follow-up - Fix a missed review comment. rs=me DONTBUILD

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9173951 [details]
Bug 1663009 - Correctly interpret addresses passed as strings to setComposeDetails. r?mkmelin

[Approval Request Comment]
WX API correctness fix. Definitely should go to 78

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9173951 [details]
Bug 1663009 - Correctly interpret addresses passed as strings to setComposeDetails. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.2.3:
https://hg.mozilla.org/releases/comm-esr78/rev/3d0ee77fe87d
https://hg.mozilla.org/releases/comm-esr78/rev/da20567544af