1663057 - Dropping one or more comma-separated plaintext addresses at end of recipient field does not make them visible in a new line

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot: Confusing visual truncation after dropping multiple addresses at end of row

+++ This bug was initially created as a clone of Bug #1601749 +++

Dragging even 50 addresses into a small space after the last pill in a row will squeeze them in there with just the last characters visible, very confusing. Instead, if the space isn't sufficient, the whole string must be moved into the next line to be fully visible immediately (as happens when you type there or paste them into same space).

Comment 1

[Alessandro Castellani [:aleca]]

I can take care of this.

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: 1663057-recipient-input.diff

This takes care of the issue, but I'm not sure if that setTimeout could be avoided by fetching the data inside the drop event.
Any suggestion?

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9177026 [details] [diff] [review]
1663057-recipient-input.diff

Review of attachment 9177026 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/mailWidgets.js
@@ +2221,5 @@
> +          // Trigger this action only if the string was dropped exactly on the
> +          // <div> inside the input field.
> +          if (input) {
> +            // Wait for the input field to get the string.
> +            setTimeout(() => {

setTimeout is not really acceptable, and will be a hack at best.

You can either grab the data from the event and use that, or use a dragend event listener

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: 1663057-recipient-input.diff

Indeed, using a timeout was very silly.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9177193 [details] [diff] [review]
1663057-recipient-input.diff

Review of attachment 9177193 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e276a5a5b5d5
Expand compose recipient input when long strings are dropped inside. r=mkmelin

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9177193 [details] [diff] [review]
1663057-recipient-input.diff

Address pills polish

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9177193 [details] [diff] [review]
1663057-recipient-input.diff

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 82.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/1de9d3a2bc7b

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 82.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/1de9d3a2bc7b

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9177193 [details] [diff] [review]
1663057-recipient-input.diff

[Triage Comment]
Approved for esr78

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 78.4.0:
https://hg.mozilla.org/releases/comm-esr78/rev/b34d6bd41ca8