Closed Bug 1663098 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25401 - webrtc wpt: fix wrong assert description

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25401 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25401
Details from upstream follow.

b'Philipp Hancke <philipp.hancke@googlemail.com>' wrote:

webrtc wpt: fix wrong assert description

copy-paste probably

BUG=chromium:1124967

Change-Id: Iba5fc35c093489724fb3bf6759e8417bb212a550
Reviewed-on: https://chromium-review.googlesource.com/2391076
WPT-Export-Revision: 99a443700c92d95308f5f0e97822424a29bd266e

PR 25401 applied with additional changes from upstream: b8ff0878e687cbb699fde08b3711c3e650f9758b
Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 19 subtests

Status Summary

Firefox

OK : 1
FAIL: 19

Chrome

OK : 1
PASS: 19

Safari

OK : 1
PASS: 8
FAIL: 11

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/webrtc/RTCRtpTransceiver-setCodecPreferences.html
setCodecPreferences() on audio transceiver with codecs returned from RTCRtpSender.getCapabilities('audio') should succeed: FAIL
setCodecPreferences() on video transceiver with codecs returned from RTCRtpReceiver.getCapabilities('video') should succeed: FAIL
setCodecPreferences() with both sender receiver codecs combined should succeed: FAIL
setCodecPreferences([]) should succeed: FAIL
setCodecPreferences() with reordered codecs should succeed: FAIL
setCodecPreferences() with only VP8 should succeed: FAIL
setCodecPreferences() with only H264 should succeed: FAIL
setCodecPreferences() should allow setting H264 as first codec: FAIL

New Tests That Don't Pass

/webrtc/RTCRtpTransceiver-setCodecPreferences.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
setCodecPreferences() on audio transceiver with codecs returned from RTCRtpSender.getCapabilities('audio') should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() on video transceiver with codecs returned from RTCRtpReceiver.getCapabilities('video') should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() with both sender receiver codecs combined should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences([]) should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() with reordered codecs should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() with only VP8 should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() with only H264 should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() should allow setting H264 as first codec: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() should allow setting VP8 as first codec: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() on audio transceiver with codecs returned from getCapabilities('video') should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with user defined codec with invalid mimeType should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with user defined codec should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with user defined codec together with codecs returned from getCapabilities() should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with modified codec clock rate should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with modified codec channel count should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with modified codec parameters should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with modified codecs returned from getCapabilities() should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() modifies the order of audio codecs in createOffer: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() modifies the order of video codecs in createOffer: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/webrtc/RTCRtpTransceiver-setCodecPreferences.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bf4501ef6444 [wpt PR 25401] - webrtc wpt: fix wrong assert description, a=testonly

https://hg.mozilla.org/mozilla-central/rev/bf4501ef6444

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.