Closed Bug 1663133 Opened 4 years ago Closed 2 years ago

Crash in [@ OOM | large | mozalloc_abort | moz_xrealloc | nsTArray_base<T>::EnsureCapacity<T> | nsTArray_Impl<T>::InsertElementAtInternal<T> | nsTArray_Impl<T>::InsertElementSortedInternal<T> | mozilla::dom::PerformanceMainThread::InsertUserEntry]

Categories

(Core :: DOM: Performance, defect, P3)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: sg, Unassigned)

Details

(Keywords: crash)

Crash Data

Crash report: https://crash-stats.mozilla.org/report/index/a57f5dd0-f707-4bac-add8-ce26d0200904

Top 10 frames of crashing thread:

0 mozglue.dll mozalloc_abort memory/mozalloc/mozalloc_abort.cpp:33
1 mozglue.dll mozalloc_handle_oom memory/mozalloc/mozalloc_oom.cpp:51
2 mozglue.dll moz_xrealloc memory/mozalloc/mozalloc.cpp:74
3 xul.dll nsTArray_base<nsTArrayInfallibleAllocator, nsTArray_RelocateUsingMemutils>::EnsureCapacity<nsTArrayInfallibleAllocator> xpcom/ds/nsTArray-inl.h:210
4 xul.dll nsTArray_Impl<RefPtr<mozilla::dom::PerformanceEntry>, nsTArrayInfallibleAllocator>::InsertElementAtInternal<nsTArrayInfallibleAllocator, mozilla::dom::PerformanceEntry*&> xpcom/ds/nsTArray.h:2518
5 xul.dll nsTArray_Impl<RefPtr<mozilla::dom::PerformanceEntry>, nsTArrayInfallibleAllocator>::InsertElementSortedInternal<nsTArrayInfallibleAllocator, mozilla::dom::PerformanceEntry*&, mozilla::dom::PerformanceEntryComparator> xpcom/ds/nsTArray.h:1632
6 xul.dll mozilla::dom::PerformanceMainThread::InsertUserEntry dom/performance/PerformanceMainThread.cpp:305
7 xul.dll mozilla::dom::Performance::Mark dom/performance/Performance.cpp:220
8 xul.dll mozilla::dom::Performance_Binding::mark dom/bindings/PerformanceBinding.cpp:604
9 xul.dll mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3225

Wouldn't it be better if mozilla::dom::PerformanceMainThread::InsertUserEntry used a fallible operation? (And if mUserEntries typically is large, then it might be better to make it a regular nsTArray rather than AutoTArray)

Crash Signature: [@ OOM | large | mozalloc_abort | moz_xrealloc | nsTArray_base<T>::EnsureCapacity<T> | nsTArray_Impl<T>::InsertElementAtInternal<T> | nsTArray_Impl<T>::InsertElementSortedInternal<T> | mozilla::dom::PerformanceMainThread::InsertUserEntry] → [@ OOM | large | mozalloc_abort | moz_xrealloc | nsTArray_base<T>::EnsureCapacity<T> | nsTArray_Impl<T>::InsertElementAtInternal<T> | nsTArray_Impl<T>::InsertElementSortedInternal<T> | mozilla::dom::PerformanceMainThread::InsertUserEntry] [@ OOM | large …
Severity: -- → S3
Priority: -- → P3
Crash Signature: | mozalloc_abort | moz_xrealloc | nsTArray_base<T>::EnsureCapacity<T> | nsTArray_Impl<T>::InsertElementAt<T> | mozilla::dom::PerformanceMainThread::InsertUserEntry] → | mozalloc_abort | moz_xrealloc | nsTArray_base<T>::EnsureCapacity<T> | nsTArray_Impl<T>::InsertElementAt<T> | mozilla::dom::PerformanceMainThread::InsertUserEntry] [@ OOM | large | mozalloc_abort | moz_xrealloc | nsTArray_base<T>::EnsureCapacity<T> | n…
Component: Performance → DOM: Performance

Closing because no crashes reported for 12 weeks.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.