166319 - support getCharacterExtents for nsIAccessibleText

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Kyle Yuan]

Gnopernicus needs these two functions.

Comment 1

[Kyle Yuan]

*** Bug 193818 has been marked as a duplicate of this bug. ***

Comment 2

[Kyle Yuan]

simford, could you spend some time on this? getCharacterExtents is very useful 
for Gnopernicus.

Comment 3

[Simford]

Attachment: patch

Comment 4

[Kyle Yuan]

Comment on attachment 115460 [details] [diff] [review]
patch

Good, work, Simford, some minor changes needed though.

>+  nsCOMPtr<nsIDocument> doc(do_QueryInterface(domDoc));
>+  if (!doc)
>+    return NS_ERROR_FAILURE;
here (and in later parts), using NS_ENSURE_TRUE(doc, NS_ERROR_FAILURE) is
better.

>+  nsRect aRect;
don't use a prefix for a local variable, it suppose to be an argument.

>+  const nsStyleFont *font = (const nsStyleFont*)
>+                                    sc->GetStyleData(eStyleStruct_Font);
merge the two lines into one.

>+  if (visibility && visibility->mLanguage) {
>+    visibility->mLanguage->GetLanguageGroup(getter_AddRefs(langGroup));
>+  }
please make sure the style of 1-line statement is consistent: either all in
brackets or not. I prefer the former.

>+  nscoord beforeWidth;
>+  if (NS_SUCCEEDED(GetText(0, aOffset, beforeString)) &&
>+      NS_SUCCEEDED(rc->GetWidth(beforeString, beforeWidth))){
please make sure always put a space before the '{'

Comment 5

[Simford]

Attachment: new patch due to comment #4

Comment 6

[Kyle Yuan]

Comment on attachment 115469 [details] [diff] [review]
new patch due to comment #4

r=kyle

Comment 7

[Henry Jia]

Comment on attachment 115469 [details] [diff] [review]
new patch due to comment #4

Seems ok. sr=Henry

Comment 8

[Simford]

Attachment: update patch

nsIStyleContext has been removed.
Make some changes.

Comment 9

[Kyle Yuan]

checked in!

Comment 10

[hacker formerly known as [e-mail]]

*** Bug 201315 has been marked as a duplicate of this bug. ***