Closed
Bug 1663367
Opened 4 years ago
Closed 4 years ago
geckoview bootstrap on windows can't find java
Categories
(Firefox Build System :: Bootstrap Configuration, defect, P3)
Tracking
(firefox82 fixed)
RESOLVED
FIXED
82 Branch
Tracking | Status | |
---|---|---|
firefox82 | --- | fixed |
People
(Reporter: mt, Assigned: rstewart)
Details
Attachments
(1 file)
The problem here is in ensure_java(), which fails to find java because it doesn't look for java.exe
. Similarly, the search for a java
executable in which() fails to add a suffix and similarly fails to find java.
Assignee | ||
Comment 1•4 years ago
|
||
We should be using shutil.which()
instead of the homebrewed which()
function. That would at least solve the second issue.
Severity: -- → S3
Priority: -- → P3
Assignee | ||
Comment 2•4 years ago
|
||
This avoids duplicating code to add the .exe
suffix, which we weren't doing before.
Updated•4 years ago
|
Assignee: nobody → rstewart
Status: NEW → ASSIGNED
Comment 3•4 years ago
|
||
Comment on attachment 9174478 [details]
Bug 1663367 - Use mozfile.which
to locate Java binary
Revision D89488 was moved to bug 1663748. Setting attachment 9174478 [details] to obsolete.
Attachment #9174478 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9174478 -
Attachment is obsolete: false
Pushed by rstewart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/01b43717a8cc Use `mozfile.which` to locate Java binary r=mhentges
Comment 5•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•