Open Bug 1663388 Opened 5 years ago Updated 5 years ago

[wpt-sync] Sync PR 25420 - Reland "webrtc: add wpt test that setCodecPreferences changes the sdp"

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25420 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25420
Details from upstream follow.

b'Philipp Hancke <philipp.hancke@googlemail.com>' wrote:

Reland "webrtc: add wpt test that setCodecPreferences changes the sdp"

This is a reland of a1d50a60453d3ed58721a648390f5903c8dfedcf
bfcache bot is now h264-enabled as of
https://chromium.googlesource.com/chromium/src.git/+/a108c6cb9eb4ebed6dda4738774948d26a69340f

Original change's description:

webrtc: add wpt test that setCodecPreferences changes the sdp

Adds a test which verifies that setCodecPreferences changes the
order of codecs in the SDP generated by createOffer.

Drive-by: close all peerconnections after the tests,
https://bugs.chromium.org/p/chromium/issues/detail?id=836871

BUG=None

Change-Id: I75d252bc43919ba2f27c6bd97493f94b3b5a2587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362024
Reviewed-by: Harald Alvestrand \<hta@chromium.org>
Commit-Queue: Philipp Hancke \<philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#799168}

Bug: None
Change-Id: I11954556e3a359028736d179b8403e08938cbd43

Reviewed-on: https://chromium-review.googlesource.com/2395396
WPT-Export-Revision: 88d8c7a89ac7ecb0cc7aaa950fa27a69629d23e0

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 19 subtests

Status Summary

Firefox

OK : 1
FAIL: 19

Chrome

OK : 1
PASS: 19

Safari

OK : 1
PASS: 8
FAIL: 11

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/webrtc/RTCRtpTransceiver-setCodecPreferences.html
setCodecPreferences() on audio transceiver with codecs returned from RTCRtpSender.getCapabilities('audio') should succeed: FAIL
setCodecPreferences() on video transceiver with codecs returned from RTCRtpReceiver.getCapabilities('video') should succeed: FAIL
setCodecPreferences() with both sender receiver codecs combined should succeed: FAIL
setCodecPreferences([]) should succeed: FAIL
setCodecPreferences() with reordered codecs should succeed: FAIL
setCodecPreferences() with only VP8 should succeed: FAIL
setCodecPreferences() with only H264 should succeed: FAIL
setCodecPreferences() should allow setting H264 as first codec: FAIL

New Tests That Don't Pass

/webrtc/RTCRtpTransceiver-setCodecPreferences.html
setCodecPreferences() on audio transceiver with codecs returned from RTCRtpSender.getCapabilities('audio') should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() on video transceiver with codecs returned from RTCRtpReceiver.getCapabilities('video') should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() with both sender receiver codecs combined should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences([]) should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() with reordered codecs should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() with only VP8 should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() with only H264 should succeed: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() should allow setting H264 as first codec: FAIL (Chrome: PASS, Safari: PASS)
setCodecPreferences() should allow setting VP8 as first codec: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() on audio transceiver with codecs returned from getCapabilities('video') should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with user defined codec with invalid mimeType should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with user defined codec should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with user defined codec together with codecs returned from getCapabilities() should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with modified codec clock rate should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with modified codec channel count should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with modified codec parameters should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() with modified codecs returned from getCapabilities() should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() modifies the order of audio codecs in createOffer: FAIL (Chrome: PASS, Safari: FAIL)
setCodecPreferences() modifies the order of video codecs in createOffer: FAIL (Chrome: PASS, Safari: FAIL)

You need to log in before you can comment on or make changes to this bug.