mach package is failing because of two missing files in package-manifest.in
Categories
(Thunderbird :: Build Config, defect)
Tracking
(thunderbird_esr78 unaffected)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
People
(Reporter: fredbezies, Assigned: rjl)
Details
Attachments
(1 file)
I noticed I cannot get mach package to work. It is shouting about two missing files:
0:19.80 Error: $SRCDIR/comm/mail/installer/package-manifest.in:388: Missing file(s): bin/components/testComponents.manifest
0:19.80 Error: $SRCDIR/comm/mail/installer/package-manifest.in:389: Missing file(s): bin/components/startupRecorder.js
After this, mach package is broken:
0:25.67 File "/home/fred/logs/mail/src/toolkit/mozapps/installer/packager.py", line 249, in <module>
0:25.67 main()
0:25.67 File "/home/fred/logs/mail/src/toolkit/mozapps/installer/packager.py", line 208, in main
0:25.67 copier.add(mozpath.join(respath, 'removed-files'), removals)
0:25.67 File "/usr/lib64/python3.8/contextlib.py", line 120, in exit
0:25.67 next(self.gen)
0:25.67 File "/home/fred/logs/mail/src/python/mozbuild/mozpack/errors.py", line 131, in accumulate
0:25.68 raise AccumulatedErrors()
0:25.68 mozpack.errors.AccumulatedErrors
0:25.70 make[3]: *** [/home/fred/logs/mail/src/toolkit/mozapps/installer/packager.mk:25: stage-package] Error 1
0:25.70 make[3]: Leaving directory '/home/fred/logs/mail/objdir-tb/comm/mail/installer'
0:25.70 make[2]: *** [/home/fred/logs/mail/src/toolkit/mozapps/installer/packager.mk:111: make-package] Error 2
0:25.70 make[2]: Leaving directory '/home/fred/logs/mail/objdir-tb/comm/mail/installer'
0:25.70 make[1]: *** [/home/fred/logs/mail/src/config/rules.mk:384: default] Error 2
0:25.70 make[1]: Leaving directory '/home/fred/logs/mail/objdir-tb/comm/mail/installer'
0:25.70 make: *** [/home/fred/logs/mail/src/comm/mail/build.mk:7: package] Error 2
0:25.70 make: Leaving directory '/home/fred/logs/mail/objdir-tb'
|
Assignee | |
Comment 1•4 years ago
|
||
Do you have both --enable-debug and --disable-tests set in your mozconfig? You'll need to remove --enable-tests for debug builds.
|
Reporter | |
Comment 2•4 years ago
|
||
(In reply to Rob Lemley [:rjl] from comment #1)
Do you have both --enable-debug and --disable-tests set in your mozconfig? You'll need to remove --enable-tests for debug builds.
No. I have this in my mozonconfig:
ac_add_options --disable-debug
ac_add_options --disable-tests
|
|
Assignee | |
Comment 3•4 years ago
|
||
Okay, I see what's going on.
I'll see about getting this fixed. In the meantime, you can remove --disable-tests from your mozconfig.
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 4•4 years ago
|
||
Fixes a mach package failure that occurs when --disable-tests is set on a nightly build. This change
is based on Firefox's browser/components/moz.build file. The bug does not occur when building Firefox.
|
|
Assignee | |
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d64aa90c6335
Include startupRecorder component in nightly and debug builds regardless of --disable-tests so that mach package succeeds. r=darktrojan DONTBUILD
|
|
Reporter | |
Comment 6•4 years ago
|
||
It is fixed. Thanks a lot!
|
|
Assignee | |
Comment 7•4 years ago
|
||
mkmelin accepted this revision.Mon, Sep 14, 04:20
Thanks! I see Firefox is running the whole block in try/catch which is why they didn't get any problems.
FWIW I did not look at the browser code, I just found what to me is the obvious solution. I thought about using a try/catch block but went with this because it seems cleaner. If we run into problems with enterprise policies though
Description
•