1663490 - Improve the OpenPGP "Signature unkown" icon

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement)

Description

[Alessandro Castellani [:aleca]]

A quick design iteration to improve the visibility of the question mark in the Signature unknown icon for S/MIME and OpenPGP encryption in the Message Pane.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: 1663490-signature-unknown.diff

I tried to use the simple question mark but at that size it didn't translate well and it looked messy.
Also, it break consistency with other icons when using alerts or warnings, which are always wrapped around colored containers.

I simply increased the size of the question mark to perfectly match the size of the triangle warning.

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 9174263 [details] [diff] [review]
1663490-signature-unknown.diff

Yes, it's better visible now.
I add a new patch with an optimized SVG plus I made the question mark white to be better visible with dark themes.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1663490-signature-unknown.diff optimized

Optimized SVG plus I made the question mark white to be better visible with dark themes

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9174267 [details] [diff] [review]
1663490-signature-unknown.diff optimized

Looks good, thanks

Comment 5

[Kai Engert (:KaiE:)]

Thank you, yes the icon is better.
I wonder if it's just me who considers it still very small overall.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5d1e1c79c5f0
Improve the OpenPGP 'Signature unkown' icon. r=Paenglab

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9174267 [details] [diff] [review]
1663490-signature-unknown.diff optimized

[Triage Comment]
Approved for beta.
Approved for esr78.

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 81.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/f6d2f6ac3ae3

Comment 9

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-esr78/rev/2f59a52810390a0658d13b0c2afeb4381bdcb79b
78.2.2