Improve the OpenPGP "Signature unkown" icon
Categories
(MailNews Core :: Security: OpenPGP, enhancement)
Tracking
(thunderbird_esr78 fixed, thunderbird81 fixed)
People
(Reporter: aleca, Assigned: aleca)
References
Details
Attachments
(1 file, 1 obsolete file)
2.91 KB,
patch
|
aleca
:
review+
aleca
:
feedback+
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
A quick design iteration to improve the visibility of the question mark in the Signature unknown
icon for S/MIME and OpenPGP encryption in the Message Pane.
Assignee | ||
Comment 1•4 years ago
|
||
I tried to use the simple question mark but at that size it didn't translate well and it looked messy.
Also, it break consistency with other icons when using alerts or warnings, which are always wrapped around colored containers.
I simply increased the size of the question mark to perfectly match the size of the triangle warning.
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Comment on attachment 9174263 [details] [diff] [review]
1663490-signature-unknown.diff
Yes, it's better visible now.
I add a new patch with an optimized SVG plus I made the question mark white to be better visible with dark themes.
Comment 3•4 years ago
|
||
Optimized SVG plus I made the question mark white to be better visible with dark themes
Assignee | ||
Comment 4•4 years ago
|
||
Comment on attachment 9174267 [details] [diff] [review]
1663490-signature-unknown.diff optimized
Looks good, thanks
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Thank you, yes the icon is better.
I wonder if it's just me who considers it still very small overall.
Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/5d1e1c79c5f0
Improve the OpenPGP 'Signature unkown' icon. r=Paenglab
Comment 7•4 years ago
|
||
Comment on attachment 9174267 [details] [diff] [review]
1663490-signature-unknown.diff optimized
[Triage Comment]
Approved for beta.
Approved for esr78.
Comment 8•4 years ago
|
||
bugherder uplift |
Thunderbird 81.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/f6d2f6ac3ae3
Comment 9•4 years ago
|
||
Description
•