Open Bug 1663539 Opened 4 years ago Updated 4 years ago

[wpt-sync] Sync PR 25427 - [css-pseudo] Support inherited text decoration properties in ::marker

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Product:
Core
Component:
Layout: Generated Content, Lists, and Counters
Type:
task

Tracking

()

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25427 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25427
Details from upstream follow.

b'Oriol Brufau <obrufau@igalia.com>' wrote:

[css-pseudo] Support inherited text decoration properties in ::marker

The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568
that inherited properties that apply to text can be set on ::marker and
should affect the marker text.

Therefore, this patch allows text-decoration-skip-ink, text-emphasis,
-webkit-text-emphasis-color, -webkit-text-emphasis-position,
-webkit-text-emphasis-style, and text-shadow in ::marker.

text-underline-position is not allowed despite being inherited because
it doesn't affect underlines specified by ancestor elements. And since
text-decoration-line is not allowed, it would be pointless.

Bug: 1031667

TEST=external/wpt/css/css-pseudo/marker-text-decoration-skip-ink.html
TEST=external/wpt/css/css-pseudo/marker-text-emphasis.html
TEST=external/wpt/css/css-pseudo/marker-text-shadow.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html

Some parsing tests fail because unprefixed text-emphasis hasn't been
implemented. And some reftests fail in legacy because ::markers with
'content: normal' are not implemented using actual text.

Change-Id: I3bd7287f0e8164a7fac0ed84dd4ec0af57a34f2e
Reviewed-on: https://chromium-review.googlesource.com/2396125
WPT-Export-Revision: d0eb6eb2006b3836e4262c6bd908a83344e43e2e

PR 25427 applied with additional changes from upstream: 289f4ec24d6e594d564f5c053807eb9be98503e7
Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 58 subtests

Status Summary

Firefox

OK : 2
PASS: 93
FAIL: 56

Chrome

OK : 2
PASS: 98
FAIL: 51

Safari

OK : 2
PASS: 48
FAIL: 101

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-pseudo/parsing/marker-supported-properties.html
Property font value 'italic small-caps 900 expanded 25px / 50px Ahem' in ::marker: FAIL linked bug:Bug 1655828

New Tests That Don't Pass

/css/css-pseudo/marker-text-decoration-skip-ink.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/marker-text-emphasis.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/marker-text-shadow.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
Animation of font in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Animation of white-space in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of hyphens in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of letter-spacing in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of line-break in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of overflow-wrap in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of tab-size in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of text-transform in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Animation of word-break in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of word-spacing in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of text-decoration-skip-ink in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of text-emphasis in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of text-emphasis-color in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of text-emphasis-position in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of text-emphasis-style in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of text-shadow in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Animation of list-style in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Transition of font in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Transition of white-space in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of hyphens in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of letter-spacing in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of line-break in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of overflow-wrap in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of tab-size in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of text-transform in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Transition of word-break in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of word-spacing in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of text-decoration-skip-ink in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of text-emphasis in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of text-emphasis-color in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of text-emphasis-position in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of text-emphasis-style in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of text-shadow in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Transition of list-style in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-pseudo/parsing/marker-supported-properties.html
Property font value 'italic small-caps 900 expanded 25px / 50px Ahem' in ::marker: FAIL (Chrome: PASS, Safari: PASS)
Property white-space value 'nowrap' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property animation value '1s linear 2s infinite alternate forwards paused anim' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Property transition value 'display 1s linear 2s' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Property hyphens value 'none' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property letter-spacing value '10px' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property line-break value 'anywhere' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property overflow-wrap value 'anywhere' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property tab-size value '10px' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property text-transform value 'uppercase' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)
Property word-break value 'break-word' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property word-spacing value '10px' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property text-decoration-skip-ink value 'none' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property text-emphasis value 'dot rgb(0, 255, 0)' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property text-emphasis-color value 'rgb(0, 255, 0)' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property text-emphasis-position value 'under left' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property text-emphasis-style value 'dot' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property text-shadow value 'rgb(0, 255, 0) 1px 2px 3px' in ::marker: FAIL (Chrome: FAIL, Safari: FAIL)
Property list-style value 'inside url('foo') decimal' in ::marker: FAIL (Chrome: PASS, Safari: FAIL)

You need to log in before you can comment on or make changes to this bug.