1663630 - Remove default topsites that match the current default engine, even if specified in the topsites collection

Status: RESOLVED FIXED

(Firefox :: Top Sites, defect, P3)

Description

[Adrian Florinescu [:aflorinescu]]

[Sugested Severity:]

S3

[Description:]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1663179#c3

[Environment:]

Windows 10
81.0b7 20200906164749

[Steps:]

1. Add https://baidu.com as a topsite in the Remote Settings configuration.
2. From the Remote Settings configuration, set the https://baidu.com to be a search shortcut.
3. Publish the changes and set Firefox to connect to the respective collection.
4. Set a Firefox profile to connect to the configuration while switching the browser.topsites.useRemoteSetting to true and setting browser.search.region to CN
5. Download a zh-CN build and setart Firefox with the previously prepared profile.
6. Start-up Firefox with the above profile configuration.
7. From about:preferences#search change the default search engine to something else than baidu.
8. From about:preferences#search change the default search engine back to baidu.

[Actual Result:]

6. default engine: baidu ; Topsite: baidu - not pinned, not search shortcut marked.
7. default engine: not_baidu; Topsite: baidu - pinned, search shortcut marked.
8. default engine: baidu; Topsite: baidu - pinned, search shortcut marked.

[Expected Result:]

6. default engine: baidu ; Topsite: baidu is not listed in the topsites
7. default engine: not_baidu; Topsite: baidu - pinned, search shortcut marked.
8. default engine: baidu; Topsite: baidu is not listed in the topsites

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1663630 - Remove default topsites that match the current default engine, even if specified in the topsites collection. r=mikedeboer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe4ea14764c6
Remove default topsites that match the current default engine, even if specified in the topsites collection. r=mikedeboer

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fe4ea14764c6

Comment 4

[Adrian Florinescu [:aflorinescu]]

This fix is not complete, in the sense that with comment 0 steps, it will still reproduce. If the topsite matches the default search engine and the topsite is set as a search shortcut, then on the engine switch away from default, the topsite will become pinned -> this causes the switch back to the default engine to not be able to remove the topsite, since it is pinned.

to exemplify, taking in account the earlier discussion related to the legacy hardcoded @google search shortcuts:

• if we have google.com set as a topsite for everyone, the locales/regions that have @google as default engine, will not have google.com topsite and when switching away from google, it will display google.com as topsite, then switching back to default engine google will hide it away again (repeat works).

• if we have google.com set as a search shortcut topsite for everyone, the locales/regions that have @google as default engine, will not have google.com search shortcut topsite and when switching away from google, it will display search shortcut google.com as topsite (which is pinned) - and switching back to google won't hide it.