1663746 - Don't resolve DNS ICE candidates if IceTransportPolicy is set to RelayOnly

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Nils Ohlmeier [:drno]]

The Chrome folks fixed an issue on their side where trying to resolve DNS names in ICE host candidates can potentially reveal some location information to an attacker:
https://bugs.chromium.org/p/webrtc/issues/detail?id=11597

There is also a spec bug for that issue https://github.com/w3c/webrtc-pc/issues/2533

We should look into doing the same thing on our end as well.

Comment 1

[Nils Ohlmeier [:drno]]

Byron can you take a look at this please?

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e1d6f7da267c00d7a1c7b3f3aaf91f47721212d

Comment 3

[Byron Campen [:bwc]]

https://github.com/rtcweb-wg/mdns-ice-candidates/issues/122

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=83e4c0ba7c426685e231eb79d8bc8a94805aa60f

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1663746: Test-case for bug. r?ng

Comment 6

[Byron Campen [:bwc]]

Attachment: Bug 1663746: Do not resolve mDNS candidates if the relay ICE policy is being used. r?ng

Depends on D125300

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1f05e235031f25b714298366d8e30c065445849

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b331e4650de
Test-case for bug. r=ng
https://hg.mozilla.org/integration/autoland/rev/61b0103d25a8
Do not resolve mDNS candidates if the relay ICE policy is being used. r=ng

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1b331e4650de
https://hg.mozilla.org/mozilla-central/rev/61b0103d25a8