./mach bootstrap (or ./mach vcs-setup) should offer ./mach install-moz-phab
Categories
(Developer Services :: Mercurial: configwizard, enhancement)
Tracking
(Not tracked)
People
(Reporter: emk, Assigned: sheehan)
Details
Attachments
(1 file)
Steps to reproduce: Run ./mach bootstrap.
Actual result:
Will you be submitting commits to Mozilla (Yn)?
Commits to Mozilla projects are typically sent to Phabricator. This is the
preferred code review tool at Mozilla.
Phabricator installation instructions are here
http://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
Expected result:
./mach bootstrap should offer ./mach install-moz-phab instead of manual instructions.
I didn't know about ./mach install-moz-phab until recently because ./mach bootstrap didn't tell me about the existence.
|
||
Comment 1•4 years ago
|
||
At the end of the mach bootstrap process, the command is displayed (https://searchfox.org/mozilla-central/source/python/mozboot/mozboot/bootstrap.py#186-191)
But yeah, I agree that it should be done by default.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
The Mercurial config wizard has a small paragraph of help text pointing users
to the Phabricator user guide when the user indicates they will be submitting
changesets to Firefox. On top of doing this, we should suggest users run
mach install-moz-phab, to improve discoverability of the command and
to avoid requiring the user read the entire guide to find this useful
tool.
Pushed by cosheehan@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/c2c163ca84ac
configwizard: suggest mach install-moz-phab in codereview step r=sylvestre
Description
•