1663917 - Update libcubeb to 1358724f73

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, task)

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1663917 - Remove patch to disable an assertion in cubeb, it's now upstream. r?kinetik

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1663917 - Update libcubeb to 1358724f73. r?#cubeb-reviewers

Depends on D89589

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1663917 - Remove special case on Windows for VOICE cubeb stream. r?kinetik

This 0 commit unties the device selection from the fact that a stream
transports voice data. Telling cubeb that the stream has voice data allows
lowering the complexity of the resampler, and lowering the impact of the
resampler on the latency.

Depends on D89590

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6b10dbb0863
Remove patch to disable an assertion in cubeb, it's now upstream. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/5d049e004a9c
Update libcubeb 1d6509f. r=cubeb-reviewers,kinetik
https://hg.mozilla.org/integration/autoland/rev/efddab14db95
Remove special case on Windows for VOICE cubeb stream. r=kinetik

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for hazard bustages on cubeb_log.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/b7368c8dcbb4d59c86cdced1e30c801a13ac2f76
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315370235&repo=autoland&lineNumber=34110

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02d7087c466d
Remove patch to disable an assertion in cubeb, it's now upstream. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/8d5dfe86bd98
Update libcubeb f39ce8a. r=cubeb-reviewers,kinetik
https://hg.mozilla.org/integration/autoland/rev/5ff7eb9b8a22
Remove special case on Windows for VOICE cubeb stream. r=kinetik

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/02d7087c466d
https://hg.mozilla.org/mozilla-central/rev/8d5dfe86bd98
https://hg.mozilla.org/mozilla-central/rev/5ff7eb9b8a22

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This has been backed out for crashes:

https://hg.mozilla.org/integration/autoland/rev/75f95f4eeb3ee0d3623c38e9d08adcc92b1a0986

Crash reports: anonymous namespace'::get_default_endpoint(`anonymous namespace'::com_ptr<T>&, __MIDL___MIDL_itf_mmdeviceapi_0000_0000_0001, __MIDL___MIDL_itf_mmdeviceapi_0000_0000_0002)

This also fixes the crash in bug 1664632.

Nightly updates have been halted and will resume after the next Nightly has been built and a release manager is available to turn updates on (1:00am UTC or later).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18143730ca80
Remove patch to disable an assertion in cubeb, it's now upstream. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/837d83a0bddd
Update libcubeb a45f6d0. r=cubeb-reviewers,kinetik
https://hg.mozilla.org/integration/autoland/rev/706c1dc89ab3
Remove special case on Windows for VOICE cubeb stream. r=kinetik

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/18143730ca80
https://hg.mozilla.org/mozilla-central/rev/837d83a0bddd
https://hg.mozilla.org/mozilla-central/rev/706c1dc89ab3

Comment 11

[Paul Adenot (:padenot)]

Attachment: crash stack

I was able to get a minidump from :jcristau and get stacks, but initially only with Visual Studio (version 2017), by loading the minidump, using the symbol server AND installing exactly the same Nightly build on my machine alongside the Nightly build I use, and pointing Visual Studio to it.

Windbg (following the instructions at https://firefox-source-docs.mozilla.org/contributing/debugging/stacktrace_windbg.html) didn't produce a useful result until I did .exepath C:\Program Files\Nightly2, presumably for the same reasons it's required in Visual Studio.

I'll update the docs. David, do you consider those docs up to date enough, and should I just add a section about debugging a minidump from crash-stats?

Comment 12

[Paul Adenot (:padenot)]

I guess it's present, in the sense that it says to load the executable, but I'll add instructions specifically for a minidump.

Comment 13

[Paul Adenot (:padenot)]

Fix upstream at https://github.com/kinetiknz/cubeb/pull/612.

Comment 14

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/mozilla-central/rev/5107e2ade42d

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91ff0dad958b
Remove patch to disable an assertion in cubeb, it's now upstream. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/5bf586f8f81a
Update libcubeb b66d915. r=cubeb-reviewers,kinetik
https://hg.mozilla.org/integration/autoland/rev/f08ef676251a
Remove special case on Windows for VOICE cubeb stream. r=kinetik

Comment 16

[(Away)]

You can do .exepath SRV*c:\symbols to make the debugger pull the binaries from the symbol server. A section for minidumps sounds fine to me.

Comment 17

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/91ff0dad958b
https://hg.mozilla.org/mozilla-central/rev/5bf586f8f81a
https://hg.mozilla.org/mozilla-central/rev/f08ef676251a

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for crashes (Bug 1665983) as suggested by jcristau:
https://hg.mozilla.org/integration/autoland/rev/9c210574d09106053c9942bc8365b9f63728ac47

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/9c210574d091

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/816dbd626f0e
Remove patch to disable an assertion in cubeb, it's now upstream. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/2bd9ec2f9cb4
Update libcubeb to 1358724f73. r=cubeb-reviewers,kinetik
https://hg.mozilla.org/integration/autoland/rev/fb01ca889dba
Remove special case on Windows for VOICE cubeb stream. r=kinetik

Comment 21

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/816dbd626f0e
https://hg.mozilla.org/mozilla-central/rev/2bd9ec2f9cb4
https://hg.mozilla.org/mozilla-central/rev/fb01ca889dba