Closed Bug 1663958 Opened 5 years ago Closed 5 years ago

Pinch to zoom performs badly with graphical glitches

Categories

(Core :: Graphics: Layers, defect, P5)

Unspecified
Android
defect

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: petru, Unassigned)

Details

Attachments

(1 file)

Attached image half-rendered view

Reported on Fenix - https://github.com/mozilla-mobile/fenix/issues/14691

Steps to reproduce

  • Use default mode with address bar at bottom.
  • I've tried with and without the zoom override accessibility option. It doesn't seem to make a difference to behaviour as far as I can tell.
  • Visit https://thetimes.co.uk
  • Wait for the privacy settings message to appear
  • Use two fingers to zoom in, then attempt to zoom out.

Expected behavior

  • You can smoothly zoom in.
  • You can smoothly zoom all the way out.

Actual behavior

On Firefox for Android, 80.1.2 (Build #2015761281), AC: 54.0.5, 02934e437, GV: 80.0.1-20200827204751, AS: 61.0.10

  • Zooming back out sometimes behaves erratically.
  • Repainting of the screen is sometimes very very slow.
  • Zooming back out leaves black rectangles over parts of the screen.
  • It is sometimes not possible to zoom all the way back out, thus obscuring the buttons you need to press. (This definitely happened to me, but I am struggling to reproduce it now.)

On Firefox Nightly for Android, Nightly 200902 06:01 (Build #2015761521) AC: 57.0.0, c84cf8e77, GV: 82.0a1-20200831091558, AS: 61.0.13

  • Zooming in sometimes doesn't work at all (you un-pinch and nothing happens).
  • Zooming back out sometimes behaves erratically.
  • Repainting of the screen is sometimes very very slow or doesn't seem to happen at all.
  • Zooming back out leaves black rectangles over parts of the screen.

Device information

OnePlus 1, Android 6.0.1

Duplicating here the following message - https://github.com/mozilla-mobile/fenix/issues/14691#issuecomment-689618891

All this took place over almost 3 minutes. That was because it took loads of time for the page to re-render after each pinch or anti-pinch. It appears as if it is doing a LOT of recalculation. The visible consent window is a centred overlay over a page. Even though none of the page is ever visible, because it is hidden under the overlay, it appears to be that it is being rejiggled/calculated when you zoom, and the consent window is probably then re-centred etc. Something about all of that makes the zoom very unstable. I think that the black patches are not pure graphical glitches... They are probably part of the page to the side of or under the overlay that has been rendered on top of it for some reason. I hope that helps.

Component: General → Panning and Zooming
Product: GeckoView → Core

Per discussion on the GH issue the problem goes away with a newer version of Android, so likely a graphics driver bug. In theory possible for us to investigate and add a workaround, but it's on the layers backend, so it seems unlikely that we will given we have only one report of this so far.

Severity: -- → S3
Component: Panning and Zooming → Graphics: Layers
OS: All → Android
Priority: -- → P5

Makes sense.
Thank you!

(In reply to amoya from comment #4)

Trying to reproduce this, I encountered these crashes:
https://crash-stats.mozilla.org/report/index/badc847b-71cc-497a-851a-f6ba00200924

https://crash-stats.mozilla.org/report/index/064aa2dd-256c-40f6-9175-848960200924

This looks like an Android Components bug that is probably unrelated to the issue here.

Flags: needinfo?(amoya)

Based on comment 2 and the discussion on GH I'm going to close this bug as incomplete.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE

(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #5)

(In reply to amoya from comment #4)

Trying to reproduce this, I encountered these crashes:
https://crash-stats.mozilla.org/report/index/badc847b-71cc-497a-851a-f6ba00200924

https://crash-stats.mozilla.org/report/index/064aa2dd-256c-40f6-9175-848960200924

This looks like an Android Components bug that is probably unrelated to the issue here.

I'll route them to AC.

Flags: needinfo?(amoya)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: