Closed Bug 1664012 Opened 4 years ago Closed 4 years ago

JS Console reports error with startup on twitter@search.mozilla.org despite twitter search being removed

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect

Tracking

(thunderbird_esr78 unaffected, thunderbird80 unaffected)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird80 --- unaffected

People

(Reporter: rjl, Assigned: mkmelin)

Details

Attachments

(1 file)

bug1664012_twitter.patch
1.57 KB, patch
sancus
: review+
Details | Diff | Splinter Review

Twitter support is removed in 78.1.2 per bug 1653792, but there is a message in the console on startup:

1599671911853	addons.xpi-utils	WARN	addMetadata: Add-on twitter@search.mozilla.org is invalid: Error: File resource://search-extensions/twitter/ does not contain a valid manifest(resource://gre/modules/addons/XPIInstall.jsm:671:11) JS Stack trace: loadManifest@XPIInstall.jsm:671:11
awaitPromise@XPIProvider.jsm:228:15
syncLoadManifest@XPIInstall.jsm:749:24
addMetadata@XPIDatabase.jsm:2807:32
processFileChanges@XPIDatabase.jsm:3251:26
checkForChanges@XPIProvider.jsm:2996:55
startup@XPIProvider.jsm:2456:12
callProvider@AddonManager.jsm:212:31
_startProvider@AddonManager.jsm:583:17
startup@AddonManager.jsm:807:14
startup@AddonManager.jsm:3462:26
observe@addonManager.js:87:29
1599671911853	addons.xpi-utils	WARN	Not uninstalling invalid item because it is a proxy file
Error while loading 'jar:file:///home/rob/apps/thunderbird/omni.ja!/chrome/messenger/search-extensions/twitter/manifest.json' (NS_ERROR_FILE_NOT_FOUND) Extension.jsm:570
    readJSON resource://gre/modules/Extension.jsm:570
    onStopRequest resource://gre/modules/NetUtil.jsm:128
    openWindowPrompt resource://gre/modules/Prompter.jsm:1229
    openPrompt resource://gre/modules/Prompter.jsm:1087
    openPromptSync resource://gre/modules/Prompter.jsm:1070
    nsIPrompt_promptPassword resource://gre/modules/Prompter.jsm:1559
    promptPassword resource://gre/modules/Prompter.jsm:1291
1599671911994	addons.xpi	WARN	Exception running bootstrap method startup on twitter@search.mozilla.org: Error: Error while loading 'jar:file:///home/rob/apps/thunderbird/omni.ja!/chrome/messenger/search-extensions/twitter/manifest.json' (NS_ERROR_FILE_NOT_FOUND)(resource://gre/modules/Extension.jsm:570:20) JS Stack trace: readJSON/</<@Extension.jsm:570:20
onStopRequest@NetUtil.jsm:128:18
openWindowPrompt@Prompter.jsm:1229:17
openPrompt@Prompter.jsm:1087:12
openPromptSync@Prompter.jsm:1070:10
nsIPrompt_promptPassword@Prompter.jsm:1559:10
promptPassword@Prompter.jsm:1291:44

This is on 78.2.2.
twitter@search.mozilla.org is still listed in prefs.js extensions.webextensions.uuids and in extension-preferences.json in the profile folder.

It's also still in engines.json in the search components source directory, but I'm not sure that's really relevant here. Looks like it's only used for running xpcshell tests?

Sancus, did the scripts to generate the search-config for Thuderbird (in bug 1612380) use mail/components/search/extensions/engines.json as input. I guess so? We'll need to re-run those scripts, then get the new file uploaded to https://thunderbird-settings.thunderbird.net/v1/buckets/thunderbird/collections/search-config/records and update our packaged dump at mail/app/settings/dumps/thunderbird/search-config.json

Assignee: nobody → mkmelin+mozilla
Flags: needinfo?(sancus)

First part.

Attachment #9174842 - Flags: review?(sancus)
Status: NEW → ASSIGNED

Ping on the review. Looks like todays nightly is failing some tests due to the stray twitter entry(?)

Comment on attachment 9174842 [details] [diff] [review]
bug1664012_twitter.patch

I have changed the server-side entries as well and deleted the Twitter record.

https://thunderbird-settings.thunderbird.net/v1/buckets/thunderbird/collections/search-config/records

Flags: needinfo?(sancus)
Attachment #9174842 - Flags: review?(sancus) → review+

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/919967d84fd0
remove twitter from engines.json. r=Sancus

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Test failures after this landed.
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=919967d84fd0ab278ac47da992da12792ad5ff52

TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/search/tests/xpcshell/test_engine_multiple_alias.js | setup - [setup : 123] Unexpected console message: Could not load engine twitter@search.mozilla.org: Error: File resource://search-extensions/twitter/ does not contain a valid manifest - false == true
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

We need to update the shipped records too, at least.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/0f9703537de7
update shipped search-config.json, to clear up toolkit/components/search/tests test failures. rs=bustage-fix

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: