1664190 - Update pdf.js to version 2.7.43

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, task)

Description

[Ryan VanderMeulen [:RyanVM]]

+++ This bug was initially created as a clone of Bug #1663803 +++

Changes since last update:
#12354 Ensure that the container div, on BaseViewer-instances, is absolutely positioned
#12352 Remove CSS variables feature-testing from PDFSidebarResizer
#12356 Set the modification date to the current day when saving
#12349 Follow-up comments on PR #12344
#12357 PDF names need to be escaped when saving

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1664190 - Update pdf.js to version 2.7.37. r=bdahl

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8db55824c06
Update pdf.js to version 2.7.37. r=bdahl

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1664190 - PDF names need to be escaped when saving. r=bdahl

This is a cherry-pick of the following upstream commit:
https://github.com/mozilla/pdf.js/pull/12357

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d8db55824c06

Comment 5

[Calixte Denizet (:calixte)]

Comment on attachment 9174910 [details]
Bug 1664190 - PDF names need to be escaped when saving. r=bdahl

Beta/Release Uplift Approval Request

• User impact if declined: Some saved forms may not be readable by Foxit
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - Open the file https://www.nta.go.jp/taxes/tetsuzuki/shinsei/annai/joyaku/annai/pdf2/250.pdf

• Click on the checkboxes on the top right
• Save the file and open it in Foxit

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Name escaping is pretty simple and we've tests to check that everything is ok.
• String changes made/needed:

Comment 6

[Calixte Denizet (:calixte)]

The problem isn't totally fixed.
Another PR is in review:
https://github.com/mozilla/pdf.js/pull/12364
So I guess we should do the uplift after cherry picking this patch.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

To make tracking easier, I'm just going to reopen this bug to keep all the relevant changes in one place.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9174905 [details]
Bug 1664190 - Update pdf.js to version 2.7.37. r=bdahl

We only need to uplift the cherry-pick patch.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Changes since last update:
#12360 Reset cursor position when focus is out of text field
#12362 Let the loadingBar have the same width as the viewerContainer
#12364 Dict keys need to be escaped too when saving

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1664190 - Update pdf.js to version 2.7.43. r=bdahl

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Try pushes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f682e37cd3ce5093874bc4282bdc695a5ea2c32 (m-c 2.7.43 update)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dae60288504211b4e6bbaaa9dfe6fb1c6c7c9b47 (m-b cherry-pick patch)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd01981c8f45
Update pdf.js to version 2.7.43. r=bdahl

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9174910 [details]
Bug 1664190 - PDF names need to be escaped when saving. r=bdahl

This has test failures that the full m-c patch doesn't have :(
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315472533&repo=try&lineNumber=7984

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9174910 [details]
Bug 1664190 - PDF names need to be escaped when saving. r=bdahl

(In reply to Ryan VanderMeulen [:RyanVM] from comment #13)

This has test failures that the full m-c patch doesn't have :(
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315472533&repo=try&lineNumber=7984

Turns out the previous iteration of the uplift patch lost a hunk. Green on Try now with that fixed. Hooray for tests.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6cd6c9db0c11ff8ee8fac73f4751bce09ef5ed7

Comment 15

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/dd01981c8f45

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9174910 [details]
Bug 1664190 - PDF names need to be escaped when saving. r=bdahl

Approved for 81.0rc1.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ed528459578d

Comment 18

[Bogdan Maris, Desktop QA]

Verified using latest nightly this is indeed better fixed on some 3rd party apps (Foxit, Chrome), but not entirely. In Acrobat there still are some issues. I think a followup bug will be required for https://github.com/mozilla/pdf.js/issues/12373. I'll mark this as verified and continue the work for the remaining issue as soon as a patch is available in another bug. If reopening this one is preferred, the status flags need to be changed, marking as verified for now.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #18)

I'll mark this as verified and continue the work for the remaining issue as soon as a patch is available in another bug.

Yeah, we'll worry about this in a new bug.

Comment 20

[Bogdan Maris, Desktop QA]

Also verified in Firefox 81.0 RC.