Closed Bug 1664230 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25470 - Read image resolution from EXIF, apply to intrinsic size See https://github.com/whatwg/html/pull/5574

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox84 fixed)

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25470 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25470
Details from upstream follow.

b'Noam Rosenthal <noam.j.rosenthal@gmail.com>' wrote:

Read image resolution from EXIF, apply to intrinsic size See https://github.com/whatwg/html/pull/5574

Currently applies to JPEG only.

Use the EXIF resolution/size information we read from the
JPEG image to determine a density-corrected preferred size,
which overrides the intrinsic size of the image.

We only apply this intrinsic size when an image has both
resolution and size information in its exif, and if the image
is origin-clean (same origin or cross-origin with CORS).

Bug: 1069755
Change-Id: I01a38c72bb46974a0c112175934cd3c2c48607a9
Reviewed-on: https://chromium-review.googlesource.com/2292219
WPT-Export-Revision: 10a7dde1efa81d615b3464746385ac3c23162822

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS: 2
FAIL: 6

Chrome

OK : 2
PASS: 2
FAIL: 6

Safari

OK : 2
PASS: 2
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/density-size-correction/density-corrected-image-svg-aspect-ratio.html: FAIL (Chrome: FAIL, Safari: FAIL)
/density-size-correction/density-corrected-image-svg.html: FAIL (Chrome: FAIL, Safari: FAIL)
/density-size-correction/density-corrected-size-img.html: FAIL (Chrome: FAIL, Safari: FAIL)
/density-size-correction/density-corrected-various-elements.html: FAIL (Chrome: FAIL, Safari: FAIL)
/density-size-correction/density-corrected-image-in-canvas.html
Density corrected size: canvas: FAIL (Chrome: FAIL, Safari: FAIL)
/density-size-correction/density-corrected-natural-size.html
density-corrected-natural-size: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd6e059d6385
[wpt PR 25470] - Read image resolution from EXIF, apply to intrinsic size See https://github.com/whatwg/html/pull/5574, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ff69aa90a73c
[wpt PR 25470] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/dd6e059d6385
https://hg.mozilla.org/mozilla-central/rev/ff69aa90a73c

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.