1664242 - classic theme, GTK3: RSS feed preview header can be hard to read when the GTK theme does not specify a tooltip background color

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Nuno Silva [:njsg]]

GTK3 themes may use a background image or gradient instead of a background color for tooltips. When using such a GTK theme with the SeaMonkey default/classic theme, the combination of foreground and background colors can result in unreadable (or hard to read) text in the feed preview header, which is styled using tooltip colors. Firefox handled this in bug 1187203.

Comment 1

[Nuno Silva [:njsg]]

Attachment: 1664242-feed-header-background-gtk

Comment 2

[Nuno Silva [:njsg]]

Comment on attachment 9174993 [details] [diff] [review]
1664242-feed-header-background-gtk

Does anything else from bug 1187203 need to be ported? chrome://global/skin/notifications.css (2.53.5beta1pre 20200907, classic theme) has the color and appearance properties added in bug 1187203, and the GtkInfoBar appearance style seems to be already supported by SeaMonkey.

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1664242-feed-header-background-gtk-2535.patch

Reformatted patch using copy. Works fine. Might not fix all cases with gtk themes but better than the current status.
r/a+ from me.
I don't think anything else need to be ported from bug 1187203.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1f3161adf8fa
Use -moz-gtk-info-bar for RSS feed CSS on Linux. r=frg

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/015af4aa803b3a75e0c4010889a86ce2a41df6ae
Port bug 1187203: "Use -moz-gtk-info-bar for RSS feed CSS on Linux" r=frg a=frg
Target 2.53.5